New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrects getrandom to behave as documented. #1283

Closed
wants to merge 2 commits into
base: development
from

Conversation

Projects
None yet
3 participants
@Azaezel
Contributor

Azaezel commented Apr 24, 2015

No description provided.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Apr 25, 2015

Contributor

Bug was introduced in #1072, so this will be merged into release-3.7 manually. This solution is still hacky, thanks to no support in DefineEngineMethod for overloaded functions. I'm fine with it for now.

Contributor

crabmusket commented Apr 25, 2015

Bug was introduced in #1072, so this will be merged into release-3.7 manually. This solution is still hacky, thanks to no support in DefineEngineMethod for overloaded functions. I'm fine with it for now.

@Duion

This comment has been minimized.

Show comment
Hide comment
@Duion

Duion Apr 25, 2015

Contributor

Better hacked than broken.

Contributor

Duion commented Apr 25, 2015

Better hacked than broken.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Apr 25, 2015

Contributor

👍

Contributor

crabmusket commented Apr 25, 2015

👍

@Duion

This comment has been minimized.

Show comment
Hide comment
@Duion

Duion Apr 25, 2015

Contributor

merge it, merge it, merge it

Contributor

Duion commented Apr 25, 2015

merge it, merge it, merge it

crabmusket added a commit that referenced this pull request Apr 26, 2015

Merge pull request #1283 from Azaezel/randiiiiiii
corrects getrandom to behave as documented.
@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Apr 26, 2015

Contributor

That counts as community feedback 😝. Merged in f8d41a2!

Contributor

crabmusket commented Apr 26, 2015

That counts as community feedback 😝. Merged in f8d41a2!

@crabmusket crabmusket closed this Apr 26, 2015

@crabmusket crabmusket added this to the 3.7 milestone Apr 26, 2015

@Azaezel Azaezel deleted the Azaezel:randiiiiiii branch May 29, 2015

RichardRanft added a commit to RichardRanft/Torque3D that referenced this pull request Jul 25, 2015

Merge pull request GarageGames#1283 from Azaezel/randiiiiiii
corrects getrandom to behave as documented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment