New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch to fix no-sound in Linux #1290

Closed
wants to merge 3 commits into
base: release-3.7
from

Conversation

Projects
None yet
3 participants
@Levitator1
Contributor

Levitator1 commented Apr 28, 2015

The default multi-threaded build under Linux had no sound, and this patch fixes that. There was a problem with the way that worker threads are awakened, and the background loading of sounds was not happening.

Addresses Issue #1265

Levitator1 added some commits Apr 28, 2015

@Areloch Areloch added this to the 3.7 milestone Apr 28, 2015

@Areloch Areloch added the Bug label Apr 28, 2015

@crabmusket crabmusket added the Linux label Apr 28, 2015

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket May 9, 2015

Contributor

Thanks for this contribution! Sorry we haven't gotten back to you before now. I'll be testing this soon. Just a note for the future - as we're using git, we prefer not to leave commented-out code in the repo. The revision history will show that information without cluttering the code. Also, we prefer comments that explain the current situation, rather than having a discussion with past developers. I'll edit that out when I merge your commit, just so you know!

Contributor

crabmusket commented May 9, 2015

Thanks for this contribution! Sorry we haven't gotten back to you before now. I'll be testing this soon. Just a note for the future - as we're using git, we prefer not to leave commented-out code in the repo. The revision history will show that information without cluttering the code. Also, we prefer comments that explain the current situation, rather than having a discussion with past developers. I'll edit that out when I merge your commit, just so you know!

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket May 9, 2015

Contributor

Merged in d4e5b47. Thanks!

Contributor

crabmusket commented May 9, 2015

Merged in d4e5b47. Thanks!

@crabmusket crabmusket closed this May 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment