New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for issue #1292 #1303

Merged
merged 3 commits into from May 25, 2015

Conversation

Projects
None yet
3 participants
@jamesu
Contributor

jamesu commented May 15, 2015

Works around the problem of string conversions for integer and float arg values by temporarily creating a string.

@crabmusket crabmusket added the Bug label May 15, 2015

@crabmusket crabmusket added this to the 3.7 milestone May 15, 2015

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket May 16, 2015

Contributor

When I run the engine, I get an immediate crash in VS2012 Windows 7 x64 on line 1760:

         sval = (char *) dRealloc(sval, newLen);

Same happens on Ubuntu 14 with gcc. It appears to happen while exec'ing a material.cs.

Contributor

crabmusket commented May 16, 2015

When I run the engine, I get an immediate crash in VS2012 Windows 7 x64 on line 1760:

         sval = (char *) dRealloc(sval, newLen);

Same happens on Ubuntu 14 with gcc. It appears to happen while exec'ing a material.cs.

@jamesu

This comment has been minimized.

Show comment
Hide comment
@jamesu

jamesu May 16, 2015

Contributor

Hmm odd, taking a look

Contributor

jamesu commented May 16, 2015

Hmm odd, taking a look

@jamesu

This comment has been minimized.

Show comment
Hide comment
@jamesu

jamesu May 16, 2015

Contributor

Not seeing a problem here. Could you be more specific with your reproduction instructions?

Contributor

jamesu commented May 16, 2015

Not seeing a problem here. Could you be more specific with your reproduction instructions?

@jamesu

This comment has been minimized.

Show comment
Hide comment
@jamesu

jamesu May 16, 2015

Contributor

Checked wrong branch, whoops

Contributor

jamesu commented May 16, 2015

Checked wrong branch, whoops

@jamesu

This comment has been minimized.

Show comment
Hide comment
@jamesu

jamesu May 16, 2015

Contributor

Fixed. Registered console values use the dataPtr variable which conflicts with sval.

Also tidied up the handling of sval so it only checks bufferLen instead of deducing its allocated based on type.

Contributor

jamesu commented May 16, 2015

Fixed. Registered console values use the dataPtr variable which conflicts with sval.

Also tidied up the handling of sval so it only checks bufferLen instead of deducing its allocated based on type.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket May 17, 2015

Contributor

Checks out on Ubuntu, now for Windows. EDIT: okay, looks good. @jamesu were you able to reproduce my initial crash? I'm going to solicit tests from a couple of others ASAP to make sure it's not just me that this is fixed for.

Contributor

crabmusket commented May 17, 2015

Checks out on Ubuntu, now for Windows. EDIT: okay, looks good. @jamesu were you able to reproduce my initial crash? I'm going to solicit tests from a couple of others ASAP to make sure it's not just me that this is fixed for.

@Areloch

This comment has been minimized.

Show comment
Hide comment
@Areloch

Areloch May 25, 2015

Contributor

Looks like it works for me as well.

Contributor

Areloch commented May 25, 2015

Looks like it works for me as well.

Areloch added a commit that referenced this pull request May 25, 2015

@Areloch Areloch merged commit eea608d into GarageGames:development May 25, 2015

1 check passed

default Merged build finished.
Details
@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket May 25, 2015

Contributor

TODO: merge into release-3.7. Need to cherry-pick instead of merging directly.

Contributor

crabmusket commented May 25, 2015

TODO: merge into release-3.7. Need to cherry-pick instead of merging directly.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket May 28, 2015

Contributor

Cherry-picked in d9436e6

Contributor

crabmusket commented May 28, 2015

Cherry-picked in d9436e6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment