New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsForestItemData: default to no bounds instead of crazy bounds #1307

Merged
merged 1 commit into from May 17, 2015

Conversation

Projects
None yet
1 participant
@crabmusket
Contributor

crabmusket commented May 16, 2015

See #1287.

As for the source of the crash, the problem originates in tsForestItemData.h. When the shape file is not found, every item gets given an invalid object box. Then, when the forest cell goes to update its bounds, it tries to update with all these invalid boxes.

If you're missing a shape file, you really don't want a crash, you want a console error, which you do currently get.

@crabmusket crabmusket added the Bug label May 16, 2015

@crabmusket crabmusket added this to the 3.7 milestone May 16, 2015

@crabmusket crabmusket changed the title from Default to no bounds instead of crazy bounds to tsForestItem: default to no bounds instead of crazy bounds May 16, 2015

@crabmusket crabmusket changed the title from tsForestItem: default to no bounds instead of crazy bounds to tsForestItemData: default to no bounds instead of crazy bounds May 16, 2015

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket May 16, 2015

Contributor

Not merged immediately because I'd like a second opinion. Does zero-size box sound like a decent default if a shapefile isn't found? As noted, there is an error. I figure Box3F::Invalid must have been chosen for a reason.

Contributor

crabmusket commented May 16, 2015

Not merged immediately because I'd like a second opinion. Does zero-size box sound like a decent default if a shapefile isn't found? As noted, there is an error. I figure Box3F::Invalid must have been chosen for a reason.

crabmusket added a commit that referenced this pull request May 17, 2015

Merge pull request #1307 from eightyeight/forestitem-default-bounds
tsForestItemData: default to no bounds instead of crazy bounds

@crabmusket crabmusket merged commit d1bcc75 into GarageGames:release-3.7 May 17, 2015

@crabmusket crabmusket deleted the crabmusket:forestitem-default-bounds branch May 17, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment