New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for rendering particles to the glow buffer #1316

Closed
wants to merge 1 commit into
base: development
from

Conversation

Projects
None yet
4 participants
@lukaspj
Contributor

lukaspj commented May 21, 2015

Fix for #1315

@lukaspj

This comment has been minimized.

Show comment
Hide comment
@lukaspj

lukaspj May 21, 2015

Contributor

Btw fun fact, the only occasion it would work earlier, was when the rendering order was such that it would render to the glow buffer exactly after rendering the particles :P Pure coincidence we didn't spot it right away :P

Contributor

lukaspj commented May 21, 2015

Btw fun fact, the only occasion it would work earlier, was when the rendering order was such that it would render to the glow buffer exactly after rendering the particles :P Pure coincidence we didn't spot it right away :P

@Azaezel

This comment has been minimized.

Show comment
Hide comment
@Azaezel

Azaezel May 21, 2015

Contributor

works

Contributor

Azaezel commented May 21, 2015

works

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket May 22, 2015

Contributor

I'm wary of publicising methods that are evidently intended to be private. Can RenderGlowMgr be a friend of RenderParticleMgr so that we can at least contain the leak? Or is there a proper way to communicate the information?

Contributor

crabmusket commented May 22, 2015

I'm wary of publicising methods that are evidently intended to be private. Can RenderGlowMgr be a friend of RenderParticleMgr so that we can at least contain the leak? Or is there a proper way to communicate the information?

@crabmusket crabmusket added the Bug label May 22, 2015

@crabmusket crabmusket added this to the 3.7 milestone May 22, 2015

@lukaspj

This comment has been minimized.

Show comment
Hide comment
@lukaspj

lukaspj May 22, 2015

Contributor

Meh, I'd say it doesn't make sense for those getter methods to be private anyways. But yeah we can make it a friend class.

Contributor

lukaspj commented May 22, 2015

Meh, I'd say it doesn't make sense for those getter methods to be private anyways. But yeah we can make it a friend class.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket May 22, 2015

Contributor

If they should be part of the public interface, can we make a ticket to make them properly public in the future? I.e. drop the underscore, and maybe move them to an already-public section?

Contributor

crabmusket commented May 22, 2015

If they should be part of the public interface, can we make a ticket to make them properly public in the future? I.e. drop the underscore, and maybe move them to an already-public section?

@Areloch

This comment has been minimized.

Show comment
Hide comment
@Areloch

Areloch May 25, 2015

Contributor

Yeah, I think we can just do a cleanup pass on it in 3.8 or 3.9.

As for this, it looks good. If you didn't spot any problems Dan, I think we can roll this one in.

Contributor

Areloch commented May 25, 2015

Yeah, I think we can just do a cleanup pass on it in 3.8 or 3.9.

As for this, it looks good. If you didn't spot any problems Dan, I think we can roll this one in.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket May 25, 2015

Contributor

Sure thing. Do the honours if you like, but you'll need to cherrypick it onto release-3.7 since the PR is targeted at development.

Contributor

crabmusket commented May 25, 2015

Sure thing. Do the honours if you like, but you'll need to cherrypick it onto release-3.7 since the PR is targeted at development.

@crabmusket crabmusket closed this May 28, 2015

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket May 28, 2015

Contributor

Cherry-picked in c5dd723.

Contributor

crabmusket commented May 28, 2015

Cherry-picked in c5dd723.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment