New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

64bit Visual Studio Projects #1331

Closed
wants to merge 2 commits into
base: development
from

Conversation

Projects
None yet
4 participants
@Areloch
Contributor

Areloch commented Jun 22, 2015

This converts the Visual Studio projects generated by the Project Manager to default as 64 bit.

@Areloch Areloch added this to the 3.8 milestone Jun 22, 2015

@Areloch

This comment has been minimized.

Show comment
Hide comment
@Areloch

Areloch Jun 22, 2015

Contributor

Note, don't know if 3.8 is fitting for this, or 3.9, but we'll be moving the default projects over to 64 bit at some point in the near-ish future, so having the PR exist now.

This only covers VS, the other templates need to be updated as well.

Contributor

Areloch commented Jun 22, 2015

Note, don't know if 3.8 is fitting for this, or 3.9, but we'll be moving the default projects over to 64 bit at some point in the near-ish future, so having the PR exist now.

This only covers VS, the other templates need to be updated as well.

@dottools

This comment has been minimized.

Show comment
Hide comment
@dottools

dottools Jun 22, 2015

Why not both 32bit and 64bit builds support?

dottools commented Jun 22, 2015

Why not both 32bit and 64bit builds support?

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Jun 22, 2015

Contributor

'Default', not 'only'. Ideal would be to work out the setup that Winterleaf had with 32 and 64 bit in a single project - though I think it's sadly not doable with CMake currently :/.

Contributor

crabmusket commented Jun 22, 2015

'Default', not 'only'. Ideal would be to work out the setup that Winterleaf had with 32 and 64 bit in a single project - though I think it's sadly not doable with CMake currently :/.

@dottools

This comment has been minimized.

Show comment
Hide comment
@dottools

dottools Jun 22, 2015

@eightyeight: Can't tell if you're replying to Areloch or to me. But the changes clearly show that it's replacing all Win32 directives with x64, not appending 64bit configurations, but replacing 32bit with 64bit. So nothing defaulting about it since then you then have to manually create Win32 configurations in Visual Studio with these changes if you wanted Win32.

dottools commented Jun 22, 2015

@eightyeight: Can't tell if you're replying to Areloch or to me. But the changes clearly show that it's replacing all Win32 directives with x64, not appending 64bit configurations, but replacing 32bit with 64bit. So nothing defaulting about it since then you then have to manually create Win32 configurations in Visual Studio with these changes if you wanted Win32.

@Areloch

This comment has been minimized.

Show comment
Hide comment
@Areloch

Areloch Jun 22, 2015

Contributor

I mean, sure we can easily do both.

The question is how much merit there is to worrying about 32bit at this point. You have to practically go out of your way to not have a 64bit compliant machine - heck, even iOS has required 64bit support in EVERYTHING since Feb. - so I'm unsure if it's even something we'd target and just leave that up to the end user to retarget if they ABSOLUTELY require 32bit.

Thoughts?

Contributor

Areloch commented Jun 22, 2015

I mean, sure we can easily do both.

The question is how much merit there is to worrying about 32bit at this point. You have to practically go out of your way to not have a 64bit compliant machine - heck, even iOS has required 64bit support in EVERYTHING since Feb. - so I'm unsure if it's even something we'd target and just leave that up to the end user to retarget if they ABSOLUTELY require 32bit.

Thoughts?

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Jun 22, 2015

Contributor

@dottools oh, when I'd discussed the issue with @Areloch I was under the impression that we were swapping the default, not replacing 32 with 64. Sorry about that. Jeff, I reckon we should definitely do both. I agree that 32 is a dwindling concern, but it's not 0 concern yet.

Contributor

crabmusket commented Jun 22, 2015

@dottools oh, when I'd discussed the issue with @Areloch I was under the impression that we were swapping the default, not replacing 32 with 64. Sorry about that. Jeff, I reckon we should definitely do both. I agree that 32 is a dwindling concern, but it's not 0 concern yet.

@Areloch

This comment has been minimized.

Show comment
Hide comment
@Areloch

Areloch Jun 23, 2015

Contributor

Sure, no problem.

If we wanna retain 32bit for a little while as a transitional period, that's no biggie. I'll update the PR with the 32bit projects back in there.

Contributor

Areloch commented Jun 23, 2015

Sure, no problem.

If we wanna retain 32bit for a little while as a transitional period, that's no biggie. I'll update the PR with the 32bit projects back in there.

@rextimmy

This comment has been minimized.

Show comment
Hide comment
@rextimmy

rextimmy Jun 23, 2015

Contributor

Would be great if the project manager had a few new functions like addProjectLibInput64,addIncludePath64 etc so you can specify different libs/directories for the modules.

Contributor

rextimmy commented Jun 23, 2015

Would be great if the project manager had a few new functions like addProjectLibInput64,addIncludePath64 etc so you can specify different libs/directories for the modules.

@crabmusket crabmusket removed this from the 3.8 milestone Jun 28, 2015

@Areloch

This comment has been minimized.

Show comment
Hide comment
@Areloch

Areloch Nov 12, 2015

Contributor

Given the shifting to using cmake as the backend, this is sorta unneded at this point, so I'm going to go ahead and close this PR.

Contributor

Areloch commented Nov 12, 2015

Given the shifting to using cmake as the backend, this is sorta unneded at this point, so I'm going to go ahead and close this PR.

@Areloch Areloch closed this Nov 12, 2015

@Areloch Areloch deleted the Areloch:64Bit_VS_Projects branch Jun 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment