New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some minor compiler warnings on Linux #1336

Merged
merged 1 commit into from Jul 1, 2015

Conversation

Projects
None yet
2 participants
@raistlin
Contributor

raistlin commented Jun 28, 2015

I am building this project on linux, gcc version 4.9.2 (Ubuntu 4.9.2-10ubuntu13), and I was shocked to get more than 20.000 compiler warnings. So I just started to clean some of them.

I plan to add more compiler warning clean commits if this little commits are accepted and merged.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Jun 28, 2015

Contributor

This is definitely significant and something I want to deal with (see #1150). Just quickly, does the warning go away if you use #if defined(_MSC_VER) && _MSC_VER > 1000? Would be preferable to having nested #ifs, but if not then I guess we'll go this way.

Contributor

crabmusket commented Jun 28, 2015

This is definitely significant and something I want to deal with (see #1150). Just quickly, does the warning go away if you use #if defined(_MSC_VER) && _MSC_VER > 1000? Would be preferable to having nested #ifs, but if not then I guess we'll go this way.

@crabmusket crabmusket added this to the 3.8 milestone Jun 28, 2015

@crabmusket crabmusket added the Defect label Jun 28, 2015

@raistlin

This comment has been minimized.

Show comment
Hide comment
@raistlin

raistlin Jun 28, 2015

Contributor

Added some more fixes.

Contributor

raistlin commented Jun 28, 2015

Added some more fixes.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Jun 28, 2015

Contributor

Looks great. I'll give this a quick test later but it should be good to go.

Contributor

crabmusket commented Jun 28, 2015

Looks great. I'll give this a quick test later but it should be good to go.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Jul 1, 2015

Contributor

Thanks for the contribution!

Contributor

crabmusket commented Jul 1, 2015

Thanks for the contribution!

crabmusket added a commit that referenced this pull request Jul 1, 2015

Merge pull request #1336 from raistlin/FixSomeWarnings
Fixed some minor compiler warnings on Linux

@crabmusket crabmusket merged commit 9bf6e0f into GarageGames:development Jul 1, 2015

@raistlin raistlin deleted the raistlin:FixSomeWarnings branch Jul 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment