New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of ease functions operations. #1354

Merged
merged 1 commit into from Jul 25, 2015

Conversation

Projects
None yet
2 participants
@Areloch
Contributor

Areloch commented Jul 14, 2015

Issue found with PVS-Studio:

Many instances of a variable being modified inside of a complex operation. This could lead to unintended results depending on the whims of the compiler.

Resolved by restructuring the functions to modify the variable first, then do the rest of the operation.

Also some minor reformatting to be more code-style compliant.

Issue found with PVS-Studio:
Many instances of a variable being modified inside of a complex operation. This could lead to unintended results depending on the whims of the compiler.

Resolved by restructuring the functions to modify the variable first, then do the rest of the operation.

@Areloch Areloch added this to the 3.8 milestone Jul 14, 2015

@crabmusket crabmusket added the Defect label Jul 14, 2015

@Areloch

This comment has been minimized.

Show comment
Hide comment
@Areloch

Areloch Jul 24, 2015

Contributor

Btw, best way I found to test this is to load a mission and select the level info. it's ambient light setting uses an ease curve. Open that editor up, and go through the various curve options(I took screencaps of each).

Then implement the fixes, and go back and compare them to the prior results. Everything matched up to the unmodified to me, and I believe Az confirmed as well.

Contributor

Areloch commented Jul 24, 2015

Btw, best way I found to test this is to load a mission and select the level info. it's ambient light setting uses an ease curve. Open that editor up, and go through the various curve options(I took screencaps of each).

Then implement the fixes, and go back and compare them to the prior results. Everything matched up to the unmodified to me, and I believe Az confirmed as well.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Jul 24, 2015

Contributor

Oh cool, I was wondering where I might find an ease. Will give it a go soon :)

Contributor

crabmusket commented Jul 24, 2015

Oh cool, I was wondering where I might find an ease. Will give it a go soon :)

crabmusket added a commit that referenced this pull request Jul 25, 2015

Merge pull request #1354 from Areloch/PVS_Cleanup_mEase
Cleanup of ease functions operations.

@crabmusket crabmusket merged commit e65afa9 into GarageGames:development Jul 25, 2015

@Areloch Areloch deleted the Areloch:PVS_Cleanup_mEase branch Jun 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment