New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert un-modified function arguments to const references. #1356

Merged
merged 2 commits into from Jul 20, 2015

Conversation

Projects
None yet
2 participants
@Areloch
Contributor

Areloch commented Jul 17, 2015

Issue found with PVS-Studio:

A lot of instances where some function args are not actually modified in any way, meaning that it is better for performance to convert them into const references. This prevents an additional copy, which can help performance.

Issue found with PVS-Studio:
A lot of instances where some function args are not actually modified in any way, meaning that it is better for performance to convert them into const references. This prevents an additional copy, which can help performance.

@Areloch Areloch added this to the 3.8 milestone Jul 17, 2015

@Areloch Areloch added the Defect label Jul 17, 2015

@Areloch

This comment has been minimized.

Show comment
Hide comment
@Areloch

Areloch Jul 19, 2015

Contributor

Fix spaces like this, you mean? I'm assuming lining the rows back up is what you were referring to.

Contributor

Areloch commented Jul 19, 2015

Fix spaces like this, you mean? I'm assuming lining the rows back up is what you were referring to.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Jul 19, 2015

Contributor

Perfect, thank you kindly. I'm pretty okay with this PR, though it begs the question whether these functions are supposed to not modify their arguments, or if they just don't.

You know what. Dumb question. Will test today.

Contributor

crabmusket commented Jul 19, 2015

Perfect, thank you kindly. I'm pretty okay with this PR, though it begs the question whether these functions are supposed to not modify their arguments, or if they just don't.

You know what. Dumb question. Will test today.

crabmusket added a commit that referenced this pull request Jul 20, 2015

Merge pull request #1356 from Areloch/PVS_Cleanup_813
Convert un-modified function arguments to const references.

@crabmusket crabmusket merged commit 4f2f1ca into GarageGames:development Jul 20, 2015

@Areloch Areloch deleted the Areloch:PVS_Cleanup_813 branch Jun 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment