New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

followobject position caching #1357

Merged
merged 2 commits into from Jul 25, 2015

Conversation

Projects
None yet
2 participants
@Azaezel
Contributor

Azaezel commented Jul 17, 2015

re-use the position of an object we're following (within reason) so we're not constantly regenning a path.

followobject position caching
re-use the position of an object we're following (within reason) so we're not constantly regenning a path.
@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Jul 17, 2015

Contributor

lastPos should probably be initialised to Point3F::MAX or something whenever we follow a new target, right?

Contributor

crabmusket commented Jul 17, 2015

lastPos should probably be initialised to Point3F::MAX or something whenever we follow a new target, right?

@Azaezel

This comment has been minimized.

Show comment
Hide comment
@Azaezel

Azaezel Jul 17, 2015

Contributor

not really. It's testing the distance between the selected object's current position and it's last target position. even on the off chance something popped up in the exact same spot, it'd still go to the same place, after all.

Contributor

Azaezel commented Jul 17, 2015

not really. It's testing the distance between the selected object's current position and it's last target position. even on the off chance something popped up in the exact same spot, it'd still go to the same place, after all.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Jul 17, 2015

Contributor

Hmm, fair enough. Please to initialise it in the FollowData constructor though. I know it's not an issue but it makes me itchy.

Contributor

crabmusket commented Jul 17, 2015

Hmm, fair enough. Please to initialise it in the FollowData constructor though. I know it's not an issue but it makes me itchy.

@Azaezel

This comment has been minimized.

Show comment
Hide comment
@Azaezel

Azaezel Jul 17, 2015

Contributor

K.

Contributor

Azaezel commented Jul 17, 2015

K.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Jul 17, 2015

Contributor

Much appreciated

Contributor

crabmusket commented Jul 17, 2015

Much appreciated

@crabmusket crabmusket added the Defect label Jul 17, 2015

@crabmusket crabmusket added this to the 3.8 milestone Jul 17, 2015

crabmusket added a commit that referenced this pull request Jul 25, 2015

Merge pull request #1357 from Azaezel/ChaseCache
followobject position caching

@crabmusket crabmusket merged commit 807aad8 into GarageGames:development Jul 25, 2015

@crabmusket crabmusket deleted the Azaezel:ChaseCache branch Jul 25, 2015

@crabmusket crabmusket restored the Azaezel:ChaseCache branch Jul 25, 2015

@Azaezel Azaezel deleted the Azaezel:ChaseCache branch Aug 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment