Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
adds minimum displacement check prior to convexSweepTest to avoid NaNs #1361
Sure, I just worry that an arbitrary constant might become nonsensical if the world is at a different scale for example. I guess, yeah, even near-zero values might cause issues? Doesn't look like there's any existing constant we can tie this to so it's not a magic number, either :/.
For future reference, this, but since the engine is a mess of floating point comparisons anyway I'm not sure if I really care enough to recommend we implement a proper relative comparison.