New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds minimum displacement check prior to convexSweepTest to avoid NaNs #1361

Merged
merged 1 commit into from Jul 27, 2015

Conversation

Projects
None yet
2 participants
@Azaezel
Contributor

Azaezel commented Jul 17, 2015

Should note depending on bullet library version, this one may or may not be needed.

@crabmusket crabmusket added the Bug label Jul 17, 2015

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Jul 25, 2015

Contributor

Do the NaNs show up only when 0s are passed? Or is it really small-magnitude vectors that are the issue?

Contributor

crabmusket commented Jul 25, 2015

Do the NaNs show up only when 0s are passed? Or is it really small-magnitude vectors that are the issue?

@Azaezel

This comment has been minimized.

Show comment
Hide comment
@Azaezel

Azaezel Jul 26, 2015

Contributor

0, but floating point happens. Best to be a bit paranoid with potential ap fatalities.

Contributor

Azaezel commented Jul 26, 2015

0, but floating point happens. Best to be a bit paranoid with potential ap fatalities.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Jul 27, 2015

Contributor

Sure, I just worry that an arbitrary constant might become nonsensical if the world is at a different scale for example. I guess, yeah, even near-zero values might cause issues? Doesn't look like there's any existing constant we can tie this to so it's not a magic number, either :/.

For future reference, this, but since the engine is a mess of floating point comparisons anyway I'm not sure if I really care enough to recommend we implement a proper relative comparison.

Contributor

crabmusket commented Jul 27, 2015

Sure, I just worry that an arbitrary constant might become nonsensical if the world is at a different scale for example. I guess, yeah, even near-zero values might cause issues? Doesn't look like there's any existing constant we can tie this to so it's not a magic number, either :/.

For future reference, this, but since the engine is a mess of floating point comparisons anyway I'm not sure if I really care enough to recommend we implement a proper relative comparison.

crabmusket added a commit that referenced this pull request Jul 27, 2015

Merge pull request #1361 from Azaezel/BulletBreak1
adds minimum displacement check prior to convexSweepTest to avoid NaNs

@crabmusket crabmusket merged commit 4721181 into GarageGames:development Jul 27, 2015

@crabmusket crabmusket added this to the 3.8 milestone Jul 27, 2015

@Azaezel Azaezel deleted the Azaezel:BulletBreak1 branch Aug 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment