New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random VS warnings #1371

Merged
merged 2 commits into from Jul 25, 2015

Conversation

Projects
None yet
1 participant
@crabmusket
Contributor

crabmusket commented Jul 23, 2015

There were causing a lot of warnings in files that include them.

crabmusket added some commits Jul 23, 2015

C4458 declaration hides class member.
There are plenty more of these, but they should be fixed by revising the
names of members to start with m, instead of fixing the local violations.
There was a previous PR for that but it went badly. Will retry again one
day.

@crabmusket crabmusket added the Defect label Jul 23, 2015

@crabmusket crabmusket added this to the 3.8 milestone Jul 23, 2015

@@ -572,10 +572,10 @@ inline MatrixF operator * ( const MatrixF &m1, const MatrixF &m2 )
return temp;
}
inline MatrixF& MatrixF::operator *= ( const MatrixF &m )
inline MatrixF& MatrixF::operator *= ( const MatrixF &m1 )

This comment has been minimized.

@crabmusket

crabmusket Jul 23, 2015

Contributor

This is m1 to align with the previous function above.

@crabmusket

crabmusket Jul 23, 2015

Contributor

This is m1 to align with the previous function above.

@crabmusket crabmusket changed the title from Random VS2015 warnings to Random VS warnings Jul 23, 2015

crabmusket added a commit that referenced this pull request Jul 25, 2015

@crabmusket crabmusket merged commit d91ec87 into GarageGames:development Jul 25, 2015

@crabmusket crabmusket deleted the crabmusket:vs2015-warnings-1 branch Jul 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment