New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-wall leads to incredibly long compile times #1385

Merged
merged 1 commit into from Aug 10, 2015

Conversation

Projects
None yet
2 participants
@Azaezel
Contributor

Azaezel commented Aug 3, 2015

(we're talking 5 minutes vs 80, here)

Alternatively, someone more competent at dealing with cmake could look into string concatenation + a switch to expose it as an option for folks that really really want to know about every possible boo-boo.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Aug 3, 2015

Contributor

Is it because there are so many warnings? :p What compiler/OS?

Contributor

crabmusket commented Aug 3, 2015

Is it because there are so many warnings? :p What compiler/OS?

@Azaezel

This comment has been minimized.

Show comment
Hide comment
@Azaezel

Azaezel Aug 3, 2015

Contributor

codeblocks/linux. and yes. the minors add up.

Contributor

Azaezel commented Aug 3, 2015

codeblocks/linux. and yes. the minors add up.

@crabmusket crabmusket added the Defect label Aug 10, 2015

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Aug 10, 2015

Contributor

All right, let's stick this in. Wall can be added back in easily enough using CXX_FLAGS, or we could provide a checkbox to do it as well.

Contributor

crabmusket commented Aug 10, 2015

All right, let's stick this in. Wall can be added back in easily enough using CXX_FLAGS, or we could provide a checkbox to do it as well.

crabmusket added a commit that referenced this pull request Aug 10, 2015

Merge pull request #1385 from Azaezel/WarningWonkiness
-wall leads to incredibly long compile times

@crabmusket crabmusket merged commit c9bf6b1 into GarageGames:development Aug 10, 2015

@crabmusket crabmusket added this to the 3.8 milestone Aug 10, 2015

@Azaezel Azaezel deleted the Azaezel:WarningWonkiness branch Aug 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment