New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL mouse wheel speed fix. #1388

Merged
merged 4 commits into from Aug 10, 2015

Conversation

Projects
None yet
3 participants
@Areloch
Contributor

Areloch commented Aug 5, 2015

Default scroll speed wasn't delta-modified, so scroll gui controls were very slow when scrolled via mouse wheel.. This corrects the issue.

SDL mouse wheel speed fix.
Default scroll speed wasn't delta-modified, so scroll gui controls were very slow when scrolled via mouse wheel.. This corrects the issue.

@Areloch Areloch added the Defect label Aug 5, 2015

@Areloch Areloch added this to the 3.8 milestone Aug 5, 2015

Areloch added some commits Aug 5, 2015

Looks like WHEEL_DELTA is defined for win and osx, but not linux. Ret…
…ooling to utilize a $pref instead, as that will let the scroll speed be modifiable for any projects that need it.
@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Aug 7, 2015

Contributor

Should the other platform implmentations also use the pref?

Contributor

crabmusket commented Aug 7, 2015

Should the other platform implmentations also use the pref?

@Areloch

This comment has been minimized.

Show comment
Hide comment
@Areloch

Areloch Aug 7, 2015

Contributor

Probably, yeah. That can be done up as a separate PR, i think.

Contributor

Areloch commented Aug 7, 2015

Probably, yeah. That can be done up as a separate PR, i think.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Aug 7, 2015

Contributor

Ok. Also should horiz scrolling also be multiplied?

Contributor

crabmusket commented Aug 7, 2015

Ok. Also should horiz scrolling also be multiplied?

@Azaezel

This comment has been minimized.

Show comment
Hide comment
@Azaezel

Azaezel Aug 7, 2015

Contributor

Frankly, hard to reproduce one way or the other without a custom mouse, but by the same token, couldn't hurt...

Contributor

Azaezel commented Aug 7, 2015

Frankly, hard to reproduce one way or the other without a custom mouse, but by the same token, couldn't hurt...

@Areloch

This comment has been minimized.

Show comment
Hide comment
@Areloch

Areloch Aug 7, 2015

Contributor

Excellent call.

Contributor

Areloch commented Aug 7, 2015

Excellent call.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Aug 7, 2015

Contributor

I'm happy with this

Contributor

crabmusket commented Aug 7, 2015

I'm happy with this

Areloch added a commit that referenced this pull request Aug 10, 2015

@Areloch Areloch merged commit 9782490 into GarageGames:development Aug 10, 2015

@Areloch Areloch deleted the Areloch:SDL_Scroll_Speed_Fix branch Jun 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment