New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning C4706: assignment within conditional expression #1391

Merged
merged 2 commits into from Aug 8, 2015

Conversation

Projects
None yet
3 participants
@Azaezel
Contributor

Azaezel commented Aug 7, 2015

No description provided.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Aug 7, 2015

Contributor

I'd prefer

GameBase *gb = gc ? gc->getThing() : NULL;

to avoid more of #1351. But good idea getting it out of the conditional

Contributor

crabmusket commented Aug 7, 2015

I'd prefer

GameBase *gb = gc ? gc->getThing() : NULL;

to avoid more of #1351. But good idea getting it out of the conditional

@Azaezel

This comment has been minimized.

Show comment
Hide comment
@Azaezel

Azaezel Aug 7, 2015

Contributor

so
GameBase *gb = gc ? gc->getCameraObject() : NULL;
if (gb)
?

Contributor

Azaezel commented Aug 7, 2015

so
GameBase *gb = gc ? gc->getCameraObject() : NULL;
if (gb)
?

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Aug 7, 2015

Contributor

You got it. Thoughts?

Contributor

crabmusket commented Aug 7, 2015

You got it. Thoughts?

@Areloch

This comment has been minimized.

Show comment
Hide comment
@Areloch

Areloch Aug 7, 2015

Contributor

Yeah, I like that better as well.

Contributor

Areloch commented Aug 7, 2015

Yeah, I like that better as well.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Aug 7, 2015

Contributor

👍

Contributor

crabmusket commented Aug 7, 2015

👍

@crabmusket crabmusket added the Defect label Aug 7, 2015

@crabmusket crabmusket added this to the 3.8 milestone Aug 7, 2015

crabmusket added a commit that referenced this pull request Aug 8, 2015

Merge pull request #1391 from Azaezel/C4706
warning C4706: assignment within conditional expression

@crabmusket crabmusket merged commit c0e82d7 into GarageGames:development Aug 8, 2015

@Azaezel Azaezel deleted the Azaezel:C4706 branch Aug 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment