New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a verifyCompatibility method to the Win32FileSystem to report case-sensitivity issues #1401

Merged
merged 1 commit into from Aug 20, 2015

Conversation

Projects
None yet
3 participants
@Azaezel
Contributor

Azaezel commented Aug 18, 2015

-triggered during debug only
-still need to expand that to handle bad directories.

Adds a verifyCompatibility method to the Win32FileSystem to report ca…
…se-sensitivity issues

-triggered during debug only
-still need to expand that to handle bad directories.
@Azaezel

This comment has been minimized.

Show comment
Hide comment
@Azaezel

Azaezel Aug 18, 2015

Contributor

doesn't catch em all, but does catch more than a few. example output:
https://gist.github.com/Azaezel/84b902169a9a66a6735a#file-gistfile1-txt-L630-L810

Contributor

Azaezel commented Aug 18, 2015

doesn't catch em all, but does catch more than a few. example output:
https://gist.github.com/Azaezel/84b902169a9a66a6735a#file-gistfile1-txt-L630-L810

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Aug 19, 2015

Contributor

I like this idea; thanks for this! Is OSX not also case-insensitive and would benefit from having this check? That can happen in the future though.

Contributor

crabmusket commented Aug 19, 2015

I like this idea; thanks for this! Is OSX not also case-insensitive and would benefit from having this check? That can happen in the future though.

@crabmusket crabmusket added this to the 3.8 milestone Aug 19, 2015

@Azaezel

This comment has been minimized.

Show comment
Hide comment
@Azaezel

Azaezel Aug 19, 2015

Contributor

OSX needs more work to be verified functional Possibly up to and including yet another pass at the opengl layer. (and for myself, still need to save up to get one to compile on instead of having to throw builds to my artists).

Do wish https://msdn.microsoft.com/en-us/library/windows/desktop/aa364419(v=vs.85).aspx didn't explicitly require the operating system itsself to be set up for case sensitivity in order to properly trigger based on FIND_FIRST_EX_CASE_SENSITIVE to catch the directories, but perhaps we'll have better luck once we do get to the apple end there.

Contributor

Azaezel commented Aug 19, 2015

OSX needs more work to be verified functional Possibly up to and including yet another pass at the opengl layer. (and for myself, still need to save up to get one to compile on instead of having to throw builds to my artists).

Do wish https://msdn.microsoft.com/en-us/library/windows/desktop/aa364419(v=vs.85).aspx didn't explicitly require the operating system itsself to be set up for case sensitivity in order to properly trigger based on FIND_FIRST_EX_CASE_SENSITIVE to catch the directories, but perhaps we'll have better luck once we do get to the apple end there.

Areloch added a commit that referenced this pull request Aug 20, 2015

Merge pull request #1401 from Azaezel/SoSensitive2
Looks good, seemed to work fine.

@Areloch Areloch merged commit 740ac50 into GarageGames:development Aug 20, 2015

Areloch added a commit that referenced this pull request Sep 17, 2015

@Azaezel Azaezel deleted the Azaezel:SoSensitive2 branch Oct 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment