New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files caught by https://github.com/GarageGames/Torque3D/pull/1401 #1402

Merged
merged 2 commits into from Sep 17, 2015

Conversation

Projects
None yet
3 participants
@Azaezel
Contributor

Azaezel commented Aug 18, 2015

No description provided.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Aug 19, 2015

Contributor

To be a real nuisance, honestly I would have gone the other way and edited the code to point to lowercase named files. Oh, but most of these cases are auto-named images from the creator, right? So they're named after classes, which have uppercase naming. Ugh :/. Also cameraBookmark -> Camera? Is the path currently incorrect?

Contributor

crabmusket commented Aug 19, 2015

To be a real nuisance, honestly I would have gone the other way and edited the code to point to lowercase named files. Oh, but most of these cases are auto-named images from the creator, right? So they're named after classes, which have uppercase naming. Ugh :/. Also cameraBookmark -> Camera? Is the path currently incorrect?

@crabmusket crabmusket added the Defect label Aug 19, 2015

@Azaezel

This comment has been minimized.

Show comment
Hide comment
@Azaezel

Azaezel Aug 19, 2015

Contributor

Going off the icon displays, the camerabookmark and camera thing got flipped because the data is identical, so git just flipped a coin on intent there. (You'll note one line further down the other gets flipped too.)

As far as methodologies goes, from @Areloch in his own followup:

https://github.com/GarageGames/Torque3D/blob/development/Engine/source/gui/worldEditor/editorIconRegistry.cpp#L88-L163https://github.com/GarageGames/Torque3D/blob/development/Engine/source/gui/worldEditor/editorIconRegistry.cpp#L136

and it also ducks around about 5 additional spots via script before resolving, so yeah, there's additional vectors that could be explored. Just not necessarily more expedient ones.

Contributor

Azaezel commented Aug 19, 2015

Going off the icon displays, the camerabookmark and camera thing got flipped because the data is identical, so git just flipped a coin on intent there. (You'll note one line further down the other gets flipped too.)

As far as methodologies goes, from @Areloch in his own followup:

https://github.com/GarageGames/Torque3D/blob/development/Engine/source/gui/worldEditor/editorIconRegistry.cpp#L88-L163https://github.com/GarageGames/Torque3D/blob/development/Engine/source/gui/worldEditor/editorIconRegistry.cpp#L136

and it also ducks around about 5 additional spots via script before resolving, so yeah, there's additional vectors that could be explored. Just not necessarily more expedient ones.

@Areloch Areloch added this to the 3.8 milestone Sep 10, 2015

@Areloch Areloch self-assigned this Sep 16, 2015

Areloch added a commit that referenced this pull request Sep 17, 2015

@Areloch Areloch merged commit 5ba5092 into GarageGames:development Sep 17, 2015

@Azaezel Azaezel deleted the Azaezel:SoSensitive3 branch Oct 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment