New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monkey pr w mergefix #1406

merged 29 commits into from Sep 4, 2015


None yet
3 participants

Areloch commented Sep 4, 2015

Companion PR to #1182

It all seems to work fine, just needs this correction to avoid the current conflict

MusicMonkey5555 and others added some commits Jan 29, 2015

Fixed issue with string replace
String replace doesn't always work correctly this fixes it.
Fixed comment
fixed an incomplete comment/documentation for displaySplashWindow.
Fixed warning
Fixed a compile warning about casting.
Fixed degree symbol not displaying
Fixed bug with degree symbol not displaying correctly in torque thanks
to the forums:
Removed unused variables
Removed unused variables.
onScroll not always called
onScroll callback wasn't always being called, fixed that.
Fixed null profile crash
If the profile was null it would crash.
Fixed bug with console expression result
Fixed a bug with the result of a console expression not always
Fixed some positioning bugs
Fixed some cursor positioning bugs in the MLTextCtrl.

Also removed parameters from function that doesn't actually take
IsActive fix & code cleanup
Now if a text edit is set to inactive you can't mouse down.
changed code
to use setVariable so code is a bit cleaner.
Fixed some small spacing
Small crash fix
Crash fix when font isn't set.
Removed unused parameters
I am not sure why there were parameters for this method when they
weren't being used (perhaps leftover from before?), but I removed them.
Fixed bug with dash character in menu item
Fixed a bug where if the text for a menu item started with - then it
would auto be disabled.
Fixed bug with bad index
Fixed a crash that would occur if an incorrect index was passed to
renderNodeName or renderNodeAxes.
Fixed odd callback bugs
Fixed bugs with callbacks, I couldn't seem to use U8 correctly in script
for some reason, but S32 works. I may have needed to use some extra
operators or something maybe, it was so long ago I can't remember what I
got in script as it was so long ago.
Removed unused code
removed some unused code.
Fixed possible divide by zero issues.
Fixed several areas in the point class that could have a divide by zero
Fixed angle conversion issues
Fixed a variable name and method that should be const.
Also fixed several angle conversion functions that didn't convert the
angle correct.
Fixed raycast bug start x position is NaN
Fixed bug in _castRay when the start x position is NaN.
Fixed bug with comparison cases of getRenderEnabled
For some reason returning true/false rather that 1/0 from
_getRenderEnabled would cause errors in some comparison cases to see if
it was true or not (would treat it as if it was a string/word rather
than a bool or int).
Fixed small warning
Fixed small warning about unused local variable.
Fixed incorrect file size returned
According to
to return the actual file size you need to use the high and low file
Added parenthesis
Added parenthesis to avoid turning height into a true/false evaluation
Fixed spacing and optimized
Fixed tab vs 3 spaces and optimized the code a bit.
Optimized code
Since floating point division is the most expensive operation, it was
Fixed tab vs spaces
Fixed tab vs spaces
Check now platform independent
Now it uses a Torque function to check so it compiles on Linux.
Update guiConsoleTextCtrl.cpp
Removed redundant assignment.

Areloch added a commit that referenced this pull request Sep 4, 2015

@Areloch Areloch merged commit 0074453 into GarageGames:development Sep 4, 2015

@crabmusket crabmusket added the Bug label Sep 8, 2015

@crabmusket crabmusket added this to the 3.8 milestone Sep 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment