Basic OpenVR Support code #1688

Merged
merged 33 commits into from Sep 14, 2016

Conversation

Projects
None yet
3 participants
@jamesu
Contributor

jamesu commented Jul 12, 2016

Adds basic OpenVR support. This also includes support for rendering controllers based on OpenVR data, though this is as of yet incomplete as there are no hooks for the button input.

Much like the oculus support, a script is also provided to handle setting up control input. However this is not hooked in by default for this PR.

The intention of this PR is more to add the support code to the engine and as a basis for identifying regressions with future dx11/gl changes.

@@ -39,6 +39,7 @@ class DecalData;
class SplashData;
class PhysicsPlayer;
class Player;
+class OpenVRTrackedObject;

This comment has been minimized.

@Azaezel

Azaezel Jul 13, 2016

Contributor

Causes non-compilation with a default-selection build. Initial suggested resolution:
#ifdef TORQUE_OPENVR
class OpenVRTrackedObject;
#else
class OpenVRTrackedObject : public GameBase
{
typedef GameBase Parent;
};
#endif

@Azaezel

Azaezel Jul 13, 2016

Contributor

Causes non-compilation with a default-selection build. Initial suggested resolution:
#ifdef TORQUE_OPENVR
class OpenVRTrackedObject;
#else
class OpenVRTrackedObject : public GameBase
{
typedef GameBase Parent;
};
#endif

@jamesu

This comment has been minimized.

Show comment
Hide comment
@jamesu

jamesu Jul 13, 2016

Contributor

@Azaezel that sounds pretty bad since your giving the fake impression that OpenVRTrackedObject is actually implemented according to the dummy stuff in the header, which could cause problems depending on the order of includes.

Could you at least tell me what compiler your using and what error your getting?

Contributor

jamesu commented Jul 13, 2016

@Azaezel that sounds pretty bad since your giving the fake impression that OpenVRTrackedObject is actually implemented according to the dummy stuff in the header, which could cause problems depending on the order of includes.

Could you at least tell me what compiler your using and what error your getting?

@Azaezel

This comment has been minimized.

Show comment
Hide comment
@Azaezel

Azaezel Jul 13, 2016

Contributor

vs2013, was spamming
use of undefined type 'OpenVRTrackedObject' without a remout and
C2065: 'OpenVRTrackedObject' : undeclared identifier with as the first two quick 'fixes'

Contributor

Azaezel commented Jul 13, 2016

vs2013, was spamming
use of undefined type 'OpenVRTrackedObject' without a remout and
C2065: 'OpenVRTrackedObject' : undeclared identifier with as the first two quick 'fixes'

@Areloch

This comment has been minimized.

Show comment
Hide comment
@Areloch

Areloch Aug 10, 2016

Contributor

Sorry for the huge wait time on testing this(had to move all the vive stuff around). I grabbed this, merged with devhead and it compiled on the first try, no problems.

I'll test it compiling in vs2013 next to make sure it's not an oddball compiler version issue.

Contributor

Areloch commented Aug 10, 2016

Sorry for the huge wait time on testing this(had to move all the vive stuff around). I grabbed this, merged with devhead and it compiled on the first try, no problems.

I'll test it compiling in vs2013 next to make sure it's not an oddball compiler version issue.

@Areloch Areloch added the New feature label Sep 1, 2016

jamesu added some commits Mar 21, 2016

More progress
- Fixed normal stereo rendering
- Beginnings of vr overlay code
Improvements to openvr code
- Overlays are implemented (sans input for the moment)
- Fixed a problem where the movemanager was using the wrong values for hmd rotation & position
@jamesu

This comment has been minimized.

Show comment
Hide comment
@jamesu

jamesu Sep 11, 2016

Contributor

Rebased to latest dev branch

Contributor

jamesu commented Sep 11, 2016

Rebased to latest dev branch

@Areloch Areloch merged commit 7e4095d into GarageGames:development Sep 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment