New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version.h #1843

Merged
merged 1 commit into from Dec 5, 2016

Conversation

Projects
None yet
5 participants
@rasteron
Contributor

rasteron commented Dec 3, 2016

No description provided.

@Duion

This comment has been minimized.

Show comment
Hide comment
@Duion

Duion Dec 4, 2016

Contributor

The next version that will come out now is 3.10, no idea how you write that in the current version number system...

Contributor

Duion commented Dec 4, 2016

The next version that will come out now is 3.10, no idea how you write that in the current version number system...

@rasteron

This comment has been minimized.

Show comment
Hide comment
@rasteron

rasteron Dec 4, 2016

Contributor

It is still the current version isn't it? which is 3.9? or 3.10?

https://github.com/GarageGames/Torque3D/releases/tag/3.9

Contributor

rasteron commented Dec 4, 2016

It is still the current version isn't it? which is 3.9? or 3.10?

https://github.com/GarageGames/Torque3D/releases/tag/3.9

@rasteron

This comment has been minimized.

Show comment
Hide comment
@rasteron

rasteron Dec 4, 2016

Contributor

..and question, how do you go to 3.10 from 3.9? Is it supposed to be 4.0?

found the 3.10 post. nvm

Contributor

rasteron commented Dec 4, 2016

..and question, how do you go to 3.10 from 3.9? Is it supposed to be 4.0?

found the 3.10 post. nvm

@Areloch

This comment has been minimized.

Show comment
Hide comment
@Areloch

Areloch Dec 5, 2016

Contributor

Haha, yeah, it can seem a bit weird for the number convention at first.

I'll go ahead and merge this now, because it's correct, and just remember to increment it myself to 3.10 when we push the 3.10 release. :)

Contributor

Areloch commented Dec 5, 2016

Haha, yeah, it can seem a bit weird for the number convention at first.

I'll go ahead and merge this now, because it's correct, and just remember to increment it myself to 3.10 when we push the 3.10 release. :)

@Areloch Areloch merged commit e996cf2 into GarageGames:development Dec 5, 2016

@rasteron

This comment has been minimized.

Show comment
Hide comment
@rasteron

rasteron Dec 5, 2016

Contributor

Ah ok thanks Jeff :)

Contributor

rasteron commented Dec 5, 2016

Ah ok thanks Jeff :)

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Dec 5, 2016

Contributor

no idea how you write that in the current version number system...

That's a very good question. Depends on how that number is used. Could make it 31000 while maintaining monotonic increase, if its role is to be compared numerically to other version numbers.

The problem is version numbers don't really map sensibly to scalars. They're more like 3D vectors.

Contributor

crabmusket commented Dec 5, 2016

no idea how you write that in the current version number system...

That's a very good question. Depends on how that number is used. Could make it 31000 while maintaining monotonic increase, if its role is to be compared numerically to other version numbers.

The problem is version numbers don't really map sensibly to scalars. They're more like 3D vectors.

@Duion

This comment has been minimized.

Show comment
Hide comment
@Duion

Duion Dec 5, 2016

Contributor

You could change the engine version instead and keep the regular version number, but this may be confusing as well since most people don't know there is an engine versioning system as well.

I would not make it 31000, I would rather make it 3910 or so, but engine version change may make sense, since there is a major shift in technology with the move to PBR.
As a bonus you could invent a new name for Torque3D, here are the current names:
https://github.com/rasteron/Torque3D/blob/a3f9365347134eecae4d3a1a30a90cf65818c39b/Engine/source/app/version.h#L30-L36
I already named my engine fork:
https://github.com/Duion/Torque3D/blob/ueberengine-master/Engine/source/app/version.h#L37

We could name the new Torque "Torque 10"

Contributor

Duion commented Dec 5, 2016

You could change the engine version instead and keep the regular version number, but this may be confusing as well since most people don't know there is an engine versioning system as well.

I would not make it 31000, I would rather make it 3910 or so, but engine version change may make sense, since there is a major shift in technology with the move to PBR.
As a bonus you could invent a new name for Torque3D, here are the current names:
https://github.com/rasteron/Torque3D/blob/a3f9365347134eecae4d3a1a30a90cf65818c39b/Engine/source/app/version.h#L30-L36
I already named my engine fork:
https://github.com/Duion/Torque3D/blob/ueberengine-master/Engine/source/app/version.h#L37

We could name the new Torque "Torque 10"

@John3

This comment has been minimized.

Show comment
Hide comment
@John3

John3 Dec 6, 2016

Contributor

This is a minor issue, AFAIK v3.10 was something kinda "unexpected", so maybe this will not gonna happen again.

BTW I did this change in this PR #1831 because I need it for the collada exporter, so the v3.10 will not forgotten.

Contributor

John3 commented Dec 6, 2016

This is a minor issue, AFAIK v3.10 was something kinda "unexpected", so maybe this will not gonna happen again.

BTW I did this change in this PR #1831 because I need it for the collada exporter, so the v3.10 will not forgotten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment