Fixes Bullet not supporting holes in terrain. #1876

Merged
merged 1 commit into from Dec 21, 2016

Conversation

Projects
None yet
3 participants
@Areloch
Contributor

Areloch commented Dec 20, 2016

Fix from @Lopuska 's PhysicsGMKRefactor branch!

@Areloch Areloch added the Bugfix label Dec 20, 2016

@rextimmy

This comment has been minimized.

Show comment
Hide comment
@rextimmy

rextimmy Dec 20, 2016

Contributor

Tested ok here. Thanks @Lopuska

Contributor

rextimmy commented Dec 20, 2016

Tested ok here. Thanks @Lopuska

@Lopuska

This comment has been minimized.

Show comment
Hide comment
@Lopuska

Lopuska Dec 20, 2016

Member

The fix follows the exact recommendations directly from Erwin Coumans on his bullet forum. Bullet is a kind of library designed to extend its feature set, so some features need to be added by redefining base classes. That's the reason holes were only implemented on PhysX, because officially bullet doesn't support heightfield holes.

Member

Lopuska commented Dec 20, 2016

The fix follows the exact recommendations directly from Erwin Coumans on his bullet forum. Bullet is a kind of library designed to extend its feature set, so some features need to be added by redefining base classes. That's the reason holes were only implemented on PhysX, because officially bullet doesn't support heightfield holes.

@Areloch

This comment has been minimized.

Show comment
Hide comment
@Areloch

Areloch Dec 21, 2016

Contributor

@Lopuska ah, that's pretty interesting. Thanks for the hard work!

Contributor

Areloch commented Dec 21, 2016

@Lopuska ah, that's pretty interesting. Thanks for the hard work!

@Areloch Areloch merged commit db7d044 into development Dec 21, 2016

@Areloch Areloch deleted the BulletHolyTerrain branch Apr 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment