enable video recording #1894

Merged
merged 1 commit into from Jan 31, 2017

Conversation

Projects
None yet
2 participants
@John3
Contributor

John3 commented Jan 2, 2017

EDIT: sry I forgot to add a description..... this add a better function of the video recording and add a shortcut.

@Areloch

This comment has been minimized.

Show comment
Hide comment
@Areloch

Areloch Jan 18, 2017

Contributor

When testing this, I ran into an issue where theora would crash in debug mode. Seemed to work fine in release, and it's not really an issue with this PR itself, so much as some oddball bug in theora. So the main question would be, should we just disable theora recording in debug?

I mean, recording already has a performance hit, and compounding that with the perf hit in debug seems like it'd be a poor combination even if there wasn't some issue in theora itself, so would it make sense for us to block theora from recording when in debug just to head off issues?

Outside the above thing, this PR seems to work perfectly well in release, so if we can decide on what to do about the debug crash, we can get this sorted out quick.

Contributor

Areloch commented Jan 18, 2017

When testing this, I ran into an issue where theora would crash in debug mode. Seemed to work fine in release, and it's not really an issue with this PR itself, so much as some oddball bug in theora. So the main question would be, should we just disable theora recording in debug?

I mean, recording already has a performance hit, and compounding that with the perf hit in debug seems like it'd be a poor combination even if there wasn't some issue in theora itself, so would it make sense for us to block theora from recording when in debug just to head off issues?

Outside the above thing, this PR seems to work perfectly well in release, so if we can decide on what to do about the debug crash, we can get this sorted out quick.

@Areloch Areloch merged commit 8985cbb into GarageGames:development Jan 31, 2017

@John3 John3 deleted the John3:enableVideoRecording branch Jan 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment