Sdl update fix #1925

Merged
merged 2 commits into from Jan 18, 2017

Conversation

Projects
None yet
2 participants
@elfprince13
Contributor

elfprince13 commented Jan 13, 2017

03c2ce4 appears to have been an incomplete update of SDL 2.0.5 and it broke the build on OS X.

@Areloch

This comment has been minimized.

Show comment
Hide comment
@Areloch

Areloch Jan 14, 2017

Contributor

Thanks for this. Thought I had got it tested on mac, but maybe there were merge shenanigans that cause me to mis-test on this end. I'll get this checked out.

Contributor

Areloch commented Jan 14, 2017

Thanks for this. Thought I had got it tested on mac, but maybe there were merge shenanigans that cause me to mis-test on this end. I'll get this checked out.

@Areloch Areloch added the Bugfix label Jan 14, 2017

@elfprince13

This comment has been minimized.

Show comment
Hide comment
@elfprince13

elfprince13 Jan 14, 2017

Contributor

I didn't notice right away after I updated because I had it set to only rebuild the application binary for my project in my IDE, instead of on ALL_BUILD, and it kept happily linking to the old version, so I wouldn't be surprised if something similar was going on for you and others.

Contributor

elfprince13 commented Jan 14, 2017

I didn't notice right away after I updated because I had it set to only rebuild the application binary for my project in my IDE, instead of on ALL_BUILD, and it kept happily linking to the old version, so I wouldn't be surprised if something similar was going on for you and others.

@Areloch Areloch merged commit 18f77a2 into GarageGames:development Jan 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment