Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upDoes better sanity checking on cleanup for the splash screen closing in SDL #1959
+20
−4
Conversation
Areloch
added
Bugfix
SDL
labels
Mar 2, 2017
Areloch
merged commit 22fdf56
into
GarageGames:development
Mar 5, 2017
Areloch
deleted the
Areloch:SDLSplashScreenCleanupSanity
branch
Jul 10, 2017
added a commit
that referenced
this pull request
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Areloch commentedMar 2, 2017
Does better sanity checking on cleanup for the splash screen closing with SDL. Could erroneously get called a second time and if we'd already cleared the images and textures, it could crash.
This fixes that.