New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhysX 3.4 support #2020

Closed
wants to merge 1 commit into
base: development
from

Conversation

Projects
None yet
4 participants
@rextimmy
Contributor

rextimmy commented Jun 8, 2017

Attempt number 2.

PhysX 3.4 support, tested on windows 10, linux mint 18.1 and macOS sierra. Added a new console variable called $Physics::gpuAccelerationAllowed (disabled by default). When enabled physx will attempt to create a cuda context and if successful will enable Gpu Rigid Body(GRB) support. If no supported nvidia hardware is found, a simple warning will be put in the log and it will than resort back to using the cpu dispatcher for everything.

GRB support is only available on windows and linux.

@Lopuska Lopuska requested a review from Areloch Jun 8, 2017

@Lopuska

This comment has been minimized.

Show comment
Hide comment
@Lopuska

Lopuska Jun 8, 2017

Member

Really cool stuff!
Sorry @Areloch, I accidentally added you as reviewer

Member

Lopuska commented Jun 8, 2017

Really cool stuff!
Sorry @Areloch, I accidentally added you as reviewer

@Lopuska Lopuska removed the request for review from Areloch Jun 8, 2017

@Areloch

This comment has been minimized.

Show comment
Hide comment
@Areloch

Areloch Jun 9, 2017

Contributor

@Lopuska Haha, no worries dude :)

@rextimmy Most excellent, good sir!

Contributor

Areloch commented Jun 9, 2017

@Lopuska Haha, no worries dude :)

@rextimmy Most excellent, good sir!

@OTHGMars

This comment has been minimized.

Show comment
Hide comment
@OTHGMars

OTHGMars Nov 14, 2017

Contributor

I tested this PR with Windows 8.1, PhysX sdk 3.4.1 and vs2015 x64. The physX build did not create the PhysX3Gpu .lib files so the game would not build without removing them from linker input. The corresponding .dll files are present in the ./bin directory and did get copied by the install projects. I don't see source for that library in the physx 3.4 repo. The game compiled and ran with them removed. This commit updates the cmake for windows. OTHGMars@55bba16
I do not have the ability to test on linux or mac.
Very nice work on the update to 3.4.

Contributor

OTHGMars commented Nov 14, 2017

I tested this PR with Windows 8.1, PhysX sdk 3.4.1 and vs2015 x64. The physX build did not create the PhysX3Gpu .lib files so the game would not build without removing them from linker input. The corresponding .dll files are present in the ./bin directory and did get copied by the install projects. I don't see source for that library in the physx 3.4 repo. The game compiled and ran with them removed. This commit updates the cmake for windows. OTHGMars@55bba16
I do not have the ability to test on linux or mac.
Very nice work on the update to 3.4.

@rextimmy

This comment has been minimized.

Show comment
Hide comment
@rextimmy

rextimmy Nov 14, 2017

Contributor

Aah ok no worries @OTHGMars , they must have changed something in the 3.4.1 release, i only tested it against the original 3.4.0 release. I'll take a look over it when i get a chance and see what is different now.

Contributor

rextimmy commented Nov 14, 2017

Aah ok no worries @OTHGMars , they must have changed something in the 3.4.1 release, i only tested it against the original 3.4.0 release. I'll take a look over it when i get a chance and see what is different now.

@rextimmy rextimmy closed this Jan 19, 2018

@rextimmy rextimmy deleted the rextimmy:physx3_4 branch Feb 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment