New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS2017 compiler workaround #2030

Merged
merged 1 commit into from Jul 6, 2017

Conversation

Projects
None yet
3 participants
@Areloch
Contributor

Areloch commented Jun 29, 2017

Works around the regressive behavior in the VSC++ compiler for VS2017 where the variadic templates would not compile correctly. Issue should be patched in future versions, so for now it'll target the 1910 version specifically.

Works around the regressive behavior in the VSC++ compiler for VS2017…
… where the variadic templates would not compile correctly. Issue should be patched in future versions, so for now it'll target the 1910 version specifically.

@Areloch Areloch added the Bugfix label Jun 29, 2017

@dottools

This comment has been minimized.

dottools commented Jun 29, 2017

Ah Visual Studio. Still the only compiler that requires dodgy workarounds. ;)

#MakeTemplatesGreatAgain

@rextimmy

This comment has been minimized.

Contributor

rextimmy commented Jun 29, 2017

👍 for leaving my DodgyVCHelper name in place :). Just a note about this, MS claim this is to be fixed with VS 15.3 release, so far testing 15.3 preview release the issue is not fixed, if the public release of 15.3 the issue is not fixed, the target version will need to include 1911

Also should tag this issue #1969

@Areloch Areloch merged commit ec400e3 into GarageGames:development Jul 6, 2017

Areloch added a commit that referenced this pull request Apr 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment