Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upVS2017 compiler workaround #2030
Conversation
Areloch
added
the
Bugfix
label
Jun 29, 2017
This comment has been minimized.
This comment has been minimized.
dottools
commented
Jun 29, 2017
|
Ah Visual Studio. Still the only compiler that requires dodgy workarounds. ;) #MakeTemplatesGreatAgain |
This comment has been minimized.
This comment has been minimized.
|
Also should tag this issue #1969 |
Areloch
merged commit ec400e3
into
GarageGames:development
Jul 6, 2017
added a commit
that referenced
this pull request
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Areloch commentedJun 29, 2017
Works around the regressive behavior in the VSC++ compiler for VS2017 where the variadic templates would not compile correctly. Issue should be patched in future versions, so for now it'll target the 1910 version specifically.