Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix Tools Toolbar width so as to include Shape Editor. #21

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

Hey Dave, this is totally trivial but it fixes the toolbar to 15 icons, so shape editor fits.

Hope you're enjoying your new job!! =-)

Chris

Owner

ChrisCalef commented on cdb31d1 Sep 24, 2012

Fixes Tools Toolbar to handle 15 icons, so Shape Editor is included.

Owner

DavidWyand-GG commented Sep 27, 2012

Hey Chris.

Great to see you around! I wanted to discuss a couple of things. The first is it would be great to post your Pull Requests to the development branch. It just makes it easier to commit your changes.

The second is I'm not quite sure what you're fixing here? I believe there are only 14 icons in the toolbar and the Shape Editor does show up. After applying your fix and loading up the Full template, my toolbar looks like this:

Tool bar

What was the 15th icon that was pushing out the Shape Editor?

Thanks!

  • Dave
Owner

DavidWyand-GG commented Nov 7, 2012

Hey Chris.

As I haven't heard back from you regarding mu question above I'm going to close this Pull Request for now. When you're able to come back and talk about your submission, feel free to reopn this request. Thanks!

Also, before we can accept any changes to the repositories we'll need you to sign the Open Source Software Agreement. We've outlined the steps in the wiki: Contributing Page Please follow those steps and let me know when you're done. Thanks!

Contributor

crabmusket commented Nov 8, 2012

I've found, after adding another editor mode (for Walkabout, if you must know), that the Shape editor does indeed get pushed off. It'd be great to actually make the toolbar resize to accommodate the actual number of editor plugins loaded. No idea where to go about making that change, but I'll look into it if I get time.

As a work around to the problem:

In game\tools\worldEditor\gui\ToolsToolbar.ed.gui

If you want to add a toolbar item....circa line 11 change:

%guiContent = new GuiContainer(EWToolsToolbar) {

...

Extent = (29 + 4) * 14 + 12 SPC "33";

to

Extent = (29 + 4) * 15 + 12 SPC "33";

If Extend was calculated dynamically even better...basically the number of toolbar items is hardcoded.

@andr3wmac andr3wmac added a commit to rextimmy/Torque3D that referenced this pull request Jun 26, 2014

@andr3wmac andr3wmac Merge pull request #21 from rextimmy/deferred_shading
 - Fixed layer blending for terrain.
ce533af

@rextimmy rextimmy pushed a commit to rextimmy/Torque3D that referenced this pull request Jan 14, 2017

@Areloch Areloch Merge pull request #21 from Azaezel/RnD_PBR_NoDX9
Rn d pbr no dx9
89729b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment