Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFixed a typo where the value of outBytesWritten was being clamped incorrectly. #2106
Conversation
Areloch
added
the
Bugfix
label
Oct 25, 2017
Areloch
merged commit 48f50d1
into
GarageGames:development
Oct 28, 2017
added a commit
that referenced
this pull request
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
block8437 commentedOct 23, 2017
There was a small typo in
platformNet.cppwhere theoutBytesWrittenwas being checked as a pointer, rather than a value, leading to the code not compiling under the latest xcode, but also this would've potentially allowed negativeoutBytesWrittenvalues since the value being checked was a pointer, rather than the value of the pointer.