New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a typo where the value of outBytesWritten was being clamped incorrectly. #2106

Merged
merged 1 commit into from Oct 28, 2017

Conversation

Projects
None yet
2 participants
@block8437
Contributor

block8437 commented Oct 23, 2017

There was a small typo in platformNet.cpp where the outBytesWritten was being checked as a pointer, rather than a value, leading to the code not compiling under the latest xcode, but also this would've potentially allowed negative outBytesWritten values since the value being checked was a pointer, rather than the value of the pointer.

@Areloch Areloch added the Bugfix label Oct 25, 2017

@Areloch Areloch merged commit 48f50d1 into GarageGames:development Oct 28, 2017

Areloch added a commit that referenced this pull request Apr 5, 2018

Merge pull request #2106 from block8437/development
Fixed a typo where the value of outBytesWritten was being clamped incorrectly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment