Increased stability Torque3D: unit-tests running without a crash.

[LuisAntonRebollo]

See the console.log after ran unitTest_runTests( "", true ). Based on a @signmotion PR #562

I added small changes to make all unit test working.

[crabmusket]

I will give this a test tonight! Thanks for the clean up.

[crabmusket]

So the unit tests run fine (706,000 sub-tests??) - there are expected to be some failures at this point, right? - but when I close the engine I get a crash in mlock.c during the editor settings XML writing. This doesn't happen if I haven't run the unit tests. Visual Studio 2012, Windows 7 x64.

EDIT: Just remembered I made some changes to the script template I was testing with. Will re-run with just Full.

EDIT: Happens with stock Full template, Debug build. The line that causes the crash is this:

LeaveCriticalSection( _locktable[locknum].lock );

[LuisAntonRebollo]

It seems that there is a problem during global ThreadPool destuctor.

Fixed using a local ThreadPool for the test.

I create an issue #599 to investigate the problem later.

[crabmusket]

Okay, I merged this into the latest development locally and I'm getting a debug break during the Journal tests - though in VS I can just click 'continue' and the tests continue, so it's not a crash. This is in debug build. However I also have a crash on quit when running this with a CMake-generated project (even without running any tests). I'll look into it further.

[LuisAntonRebollo]

I'm getting a debug break during the Journal tests

I will try to reproduce the problem.

However I also have a crash on quit when running this with a CMake-generated project (even without running any tests). I'll look into it further.

I'm working on solve this.

[crabmusket]

Not convinced I'll be able to reproduce the Journal break for you, but I'll give it a go. It hung up in a couple of different places in the Windows platform code.

[LuisAntonRebollo]

However I also have a crash on quit when running this with a CMake-generated project (even without running any tests). I'll look into it further.

Fix crash on exit T3D when build with CMake. #628

I'm getting a debug break during the Journal tests

I'll check tomorrow.

[LuisAntonRebollo]

I have merged with development branch + #628 and i get a crash when execute the unit tests (after test are finished or at app exit).

HEAP: Free Heap block ADDRESS modified at ADDRESS after it was freed

So far I could not find the cause ... I have to dedicate more time.

[LuisAntonRebollo]

Forgot to remove TestingProcess::process form Process's signal. This cause Process notify a deleted object and corrupt memory.

[LuisAntonRebollo]

I think i have fixed the problem, not related to ThreadPool (reverted changes... i need to close #599).

Forgot to remove TestingProcess::process form Process's signal. This cause Process notify a deleted object and corrupt memory.

Anyone can verify that everything is working properly?

[crabmusket]

Seems to be working.