New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GFXDevice::setupGenericShaders for support non Fixed Fuction Pipelines. #608

Merged
merged 1 commit into from Nov 30, 2014

Conversation

Projects
None yet
2 participants
@LuisAntonRebollo
Contributor

LuisAntonRebollo commented Apr 13, 2014

OpenGL and DirectX11 not support FFP, and GFDevice::disableShaders has not the necessary information to decide the shader to be used.

GFDevice::SetupGenericShaders is used instead of GFDevice::disableShaders.

GFDevice::disableShaders will be deprecated on T3D 4.0

Use GFXDevice::setupGenericShaders for support non Fixed Fuction Pipe…
…lines.

OpenGL and DirectX11 not support FFP, and GFDevice::disableShaders has not the necessary information to decide the shader to be used.

GFDevice::SetupGenericShaders is used instead of GFDevice::disableShaders.

GFDevice::disableShaders will be deprecated on T3D 4.0

@LuisAntonRebollo LuisAntonRebollo referenced this pull request Apr 13, 2014

Closed

Add OpenGL 3.2 renderer #587

23 of 23 tasks complete
@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Apr 13, 2014

Contributor

Should we put some sort of deprecation warning on disableShaders in 3.6 or 3.7?

Contributor

crabmusket commented Apr 13, 2014

Should we put some sort of deprecation warning on disableShaders in 3.6 or 3.7?

@crabmusket crabmusket added this to the 4.0 milestone Apr 13, 2014

@LuisAntonRebollo

This comment has been minimized.

Show comment
Hide comment
@LuisAntonRebollo

LuisAntonRebollo Apr 16, 2014

Contributor

Yes.

We will have to discuss the process of deprecation. Compiler warnings, add a place on documentation, and code commenting.

Contributor

LuisAntonRebollo commented Apr 16, 2014

Yes.

We will have to discuss the process of deprecation. Compiler warnings, add a place on documentation, and code commenting.

@LuisAntonRebollo LuisAntonRebollo modified the milestones: OpenGL3, 4.0 Apr 17, 2014

LuisAntonRebollo added a commit that referenced this pull request Nov 30, 2014

Merge pull request #608 from BeamNG/use_gfxdevice_setupgenericshaders
Use GFXDevice::setupGenericShaders for support non Fixed Fuction Pipelines.

@LuisAntonRebollo LuisAntonRebollo merged commit 1c95ce2 into GarageGames:development Nov 30, 2014

1 check passed

default Merged build finished.
Details

@LuisAntonRebollo LuisAntonRebollo deleted the BeamNG:use_gfxdevice_setupgenericshaders branch Nov 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment