New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WaterObject TODO: Retrieve sampler numbers from parameter handles, see r22631. #616

Merged
merged 1 commit into from Sep 30, 2014

Conversation

Projects
None yet
3 participants
@LuisAntonRebollo
Contributor

LuisAntonRebollo commented Apr 17, 2014

It is better to use data from shader.
If the order of the samplers in the shader is changed, this code will work correctly.

@LuisAntonRebollo LuisAntonRebollo referenced this pull request Apr 17, 2014

Closed

Add OpenGL 3.2 renderer #587

23 of 23 tasks complete

@LuisAntonRebollo LuisAntonRebollo added this to the OpenGL3 milestone Apr 17, 2014

@tdev

This comment has been minimized.

Show comment
Hide comment
@tdev

tdev May 23, 2014

Member

even mentioned in the comment. merge?

Member

tdev commented on 3995b97 May 23, 2014

even mentioned in the comment. merge?

Areloch added a commit that referenced this pull request Sep 30, 2014

Merge pull request #616 from BeamNG/water_object_use_shader_param
Fix WaterObject TODO: Retrieve sampler numbers from parameter handles, see r22631.

@Areloch Areloch merged commit eeb97ff into GarageGames:development Sep 30, 2014

1 check passed

default Merged build finished.
Details

@LuisAntonRebollo LuisAntonRebollo deleted the BeamNG:water_object_use_shader_param branch Nov 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment