New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GLSL Shadergen. #621

Merged
merged 2 commits into from May 23, 2014

Conversation

Projects
None yet
3 participants
@LuisAntonRebollo
Contributor

LuisAntonRebollo commented Apr 17, 2014

Not used on DX9.

@LuisAntonRebollo LuisAntonRebollo added this to the OpenGL3 milestone Apr 17, 2014

@LuisAntonRebollo LuisAntonRebollo referenced this pull request Apr 17, 2014

Closed

Add OpenGL 3.2 renderer #587

23 of 23 tasks complete
@dottools

This comment has been minimized.

Show comment
Hide comment
@dottools

dottools Apr 17, 2014

Not used on DX9 isn't an informative commit comment. Massive changes in this pull request and as such deserves a better summary of what's been fixed, changed, or new features added or something.

dottools commented Apr 17, 2014

Not used on DX9 isn't an informative commit comment. Massive changes in this pull request and as such deserves a better summary of what's been fixed, changed, or new features added or something.

@LuisAntonRebollo

This comment has been minimized.

Show comment
Hide comment
@LuisAntonRebollo

LuisAntonRebollo Apr 17, 2014

Contributor

You are right that is not a very explanatory comment hehe.

With Not used on DX9., I mean that these changes will not break DX9 and we can do a safe merge.

Massive changes in this pull request and as such deserves a better summary of what's been fixed, changed, or new features added or something.

Currently it is impossible for me to devote all that time.

The code is based on this branch: https://github.com/BeamNG/Torque3D/tree/dev_linux_opengl . And you can find more information here: http://www.garagegames.com/community/forums/viewthread/133262

I think we can assume that the OpenGL code works better than the old one. And it's better merge all code that will not break DX9 and then fix any OpenGL problem.

Contributor

LuisAntonRebollo commented Apr 17, 2014

You are right that is not a very explanatory comment hehe.

With Not used on DX9., I mean that these changes will not break DX9 and we can do a safe merge.

Massive changes in this pull request and as such deserves a better summary of what's been fixed, changed, or new features added or something.

Currently it is impossible for me to devote all that time.

The code is based on this branch: https://github.com/BeamNG/Torque3D/tree/dev_linux_opengl . And you can find more information here: http://www.garagegames.com/community/forums/viewthread/133262

I think we can assume that the OpenGL code works better than the old one. And it's better merge all code that will not break DX9 and then fix any OpenGL problem.

@tdev

This comment has been minimized.

Show comment
Hide comment
@tdev

tdev commented May 23, 2014

👍

tdev pushed a commit that referenced this pull request May 23, 2014

@tdev tdev merged commit c850d60 into GarageGames:development May 23, 2014

@LuisAntonRebollo LuisAntonRebollo deleted the BeamNG:glsl_shadergen branch May 25, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment