New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecated functionality. T3D handles this in the reflector class. #721

Merged
merged 1 commit into from Oct 14, 2014

Conversation

Projects
None yet
3 participants
@Azaezel
Contributor

Azaezel commented Jul 9, 2014

No description provided.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Jul 10, 2014

Contributor

Might these variables be in use by somebody? Is it safe to outright remove them instead of adding a deprecation warning to the console members, then removing them in 3.7 or 4.0?

Contributor

crabmusket commented Jul 10, 2014

Might these variables be in use by somebody? Is it safe to outright remove them instead of adding a deprecation warning to the console members, then removing them in 3.7 or 4.0?

@Azaezel

This comment has been minimized.

Show comment
Hide comment
@Azaezel

Azaezel Jul 10, 2014

Contributor

Highly doubtful from what I've been able to determine thus-far, but your call.

Contributor

Azaezel commented Jul 10, 2014

Highly doubtful from what I've been able to determine thus-far, but your call.

@Azaezel

This comment has been minimized.

Show comment
Hide comment
@Azaezel

Azaezel Aug 2, 2014

Contributor

Forgot to mention:

"@note The dynamic cubemap functionality in CubemapData has been depreciated in favor of ReflectorDesc.\n"

Contributor

Azaezel commented Aug 2, 2014

Forgot to mention:

"@note The dynamic cubemap functionality in CubemapData has been depreciated in favor of ReflectorDesc.\n"

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Aug 2, 2014

Contributor

Ok well I am satisfied. We kind of have to play things a bit fast and loose till we get proper processes set up, and we can do that while relatively few people use the engine from source*. I still want someone else on the committee to sign off on this since I don't know my way around the rendering subsystems.

*I know this because reasons.

Contributor

crabmusket commented Aug 2, 2014

Ok well I am satisfied. We kind of have to play things a bit fast and loose till we get proper processes set up, and we can do that while relatively few people use the engine from source*. I still want someone else on the committee to sign off on this since I don't know my way around the rendering subsystems.

*I know this because reasons.

@andr3wmac

This comment has been minimized.

Show comment
Hide comment
@andr3wmac

andr3wmac Aug 2, 2014

Contributor

I looked it over and searched the code base for references. It's not used with any of the current dynamic cubemapping code. I'd say it's a safe change. If someone was using it, they would have had to add their own code to make use of it, at which point they should be equally capable of restoring the removed code.

Contributor

andr3wmac commented Aug 2, 2014

I looked it over and searched the code base for references. It's not used with any of the current dynamic cubemapping code. I'd say it's a safe change. If someone was using it, they would have had to add their own code to make use of it, at which point they should be equally capable of restoring the removed code.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Aug 3, 2014

Contributor

Ok, well, I guess we can have it in 3.6 if it's ready to merge? You be the judge.

Contributor

crabmusket commented Aug 3, 2014

Ok, well, I guess we can have it in 3.6 if it's ready to merge? You be the judge.

@Azaezel

This comment has been minimized.

Show comment
Hide comment
@Azaezel

Azaezel Aug 29, 2014

Contributor

Rolled into #766

Contributor

Azaezel commented Aug 29, 2014

Rolled into #766

@Azaezel Azaezel closed this Aug 29, 2014

@Azaezel

This comment has been minimized.

Show comment
Hide comment
@Azaezel

Azaezel Sep 4, 2014

Contributor

re-opened by request.

Contributor

Azaezel commented Sep 4, 2014

re-opened by request.

@Azaezel Azaezel reopened this Sep 4, 2014

@crabmusket crabmusket added this to the 3.7 milestone Oct 11, 2014

crabmusket added a commit that referenced this pull request Oct 14, 2014

Merge pull request #721 from Azaezel/CubemapCleanup
deprecated functionality. T3D handles this in the reflector class.

@crabmusket crabmusket merged commit 561e26e into GarageGames:development Oct 14, 2014

1 check passed

default Merged build finished.
Details

@Azaezel Azaezel deleted the Azaezel:CubemapCleanup branch Oct 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment