New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sahara #726

Closed
wants to merge 2 commits into
base: development
from

Conversation

Projects
None yet
3 participants
@qdelpeche

qdelpeche commented Jul 11, 2014

This is the inclusion of the material accumalator called Sahara from BitGap games. Konrad Kiss has given us permission to realease this under MIT.

@crabmusket crabmusket added this to the 3.7 milestone Jul 11, 2014

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Jul 11, 2014

Contributor

Targeted at 3.7, and nice work with the pull request. Smooth. However, we may decide to hold off on this until we make some modifications as Andrew was talking about. I'll leave it to him and the others to decide.

Contributor

crabmusket commented Jul 11, 2014

Targeted at 3.7, and nice work with the pull request. Smooth. However, we may decide to hold off on this until we make some modifications as Andrew was talking about. I'll leave it to him and the others to decide.

@LuisAntonRebollo

This comment has been minimized.

Show comment
Hide comment
@LuisAntonRebollo

LuisAntonRebollo Jul 11, 2014

Contributor

Thx for your work.

This PR some issues with dedicated gcc build: http://t3dci.org/job/T3D_PR_development_dedicated_dev_ubuntu_gcc/157/console

I think it's becouse some shadergen files are not on Engine/source/shaderGen/HLSL directory.

Contributor

LuisAntonRebollo commented Jul 11, 2014

Thx for your work.

This PR some issues with dedicated gcc build: http://t3dci.org/job/T3D_PR_development_dedicated_dev_ubuntu_gcc/157/console

I think it's becouse some shadergen files are not on Engine/source/shaderGen/HLSL directory.

@qdelpeche

This comment has been minimized.

Show comment
Hide comment
@qdelpeche

qdelpeche Jul 14, 2014

@LuisAntonRebollo - The issue here seems to be a linking order problem. I can see .o and .d file in the shaderGen folder after the first pass of compilation ... but I can't figure out why it doesn't link correctly.

qdelpeche commented Jul 14, 2014

@LuisAntonRebollo - The issue here seems to be a linking order problem. I can see .o and .d file in the shaderGen folder after the first pass of compilation ... but I can't figure out why it doesn't link correctly.

@LuisAntonRebollo

This comment has been minimized.

Show comment
Hide comment
@LuisAntonRebollo

LuisAntonRebollo Jul 15, 2014

Contributor

I'll fix the problem when we're ready to merge thi PR.Currently we have many things to do for 3.6

Contributor

LuisAntonRebollo commented Jul 15, 2014

I'll fix the problem when we're ready to merge thi PR.Currently we have many things to do for 3.6

@crabmusket crabmusket referenced this pull request Aug 31, 2014

Closed

Accumulation volumes #768

@crabmusket crabmusket closed this Oct 25, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment