New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jamesu's console function refactor #842

Merged
merged 13 commits into from Oct 23, 2014

Conversation

Projects
None yet
3 participants
@crabmusket
Contributor

crabmusket commented Oct 19, 2014

Contains #81 and #664 merged with current dev head. All appears to be in order. Testing will be achieved by merging this into the dev branch and letting people find breakages.

jamesu and others added some commits Sep 23, 2012

Beginnings of the "pass everything using a native type wrapper" conso…
…le code.

- ConsoleValue class is now the base value class.
- ConsoleValueRef is now used to supply function parameters. Values are disposable.
- Script functions return values instead of just strings where possible.
- Variables can be disposable strings
- Bytecode changed

Fix the issues with console method parameters and fields which prevented missions from loading.
Improvements to console refactor code
- Prevent stack corruption in a few places
- Use correct type in printfs
- Reduce type conversions in EngineApi & dAto*
- Fix compilation on GCC
- Tidy up code
Merge branch 'master' into console-func-refactor
Conflicts:
	Engine/source/app/net/net.cpp
	Engine/source/console/astNodes.cpp
	Engine/source/console/compiledEval.cpp
	Engine/source/console/console.h
	Engine/source/console/consoleInternal.h
	Engine/source/console/engineAPI.h

@crabmusket crabmusket added this to the 3.7 milestone Oct 19, 2014

Merge branch 'development' into console-func-refactor
Conflicts:
	Engine/source/console/compiledEval.cpp

@crabmusket crabmusket changed the title from jamesu's console func refactor to jamesu's console function refactor Oct 19, 2014

crabmusket added a commit that referenced this pull request Oct 23, 2014

@crabmusket crabmusket merged commit 81a3850 into GarageGames:development Oct 23, 2014

1 check passed

default Merged build finished.
Details

@crabmusket crabmusket deleted the crabmusket:console-func-refactor branch Oct 23, 2014

This was referenced Oct 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment