New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev forest wind emitter improvement #896

Closed
wants to merge 3 commits into
base: development
from

Conversation

Projects
None yet
2 participants
@Winterleaf
Contributor

Winterleaf commented Nov 4, 2014

Fixes the sphere of red from disappearing when the camera is inside the range of the wind.

Winterleaf added some commits Nov 4, 2014

So the problem is that when your inside the sphere it won't render so…
… it might make someone

think that it's not working right.  So what I did was determine if the camera is inside the sphere.
If the camera is inside the sphere, then I find the distance from the center of the sphere to the camera
Round down and use that as the radius to draw the sphere.
That way if someone zooms in or out, their screen is still showing the sphere.

@crabmusket crabmusket added the Defect label Nov 4, 2014

@crabmusket crabmusket added this to the 3.7 milestone Nov 4, 2014

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Nov 4, 2014

Contributor

Thanks for the quick response!

Contributor

crabmusket commented Nov 4, 2014

Thanks for the quick response!

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Dec 7, 2014

Contributor

Spacing issues. distanceTo addition looks fine, but it should be added to all Point classes for consistency. As for insideSphere, do we need a new method for that? Could we not use SphereF(pos, radius).isContained(point)? I get that this is more convenient, but it still irks me :P. At the very least, add it to all other point classes as well. Point2 should have insideCircle.

Contributor

crabmusket commented Dec 7, 2014

Spacing issues. distanceTo addition looks fine, but it should be added to all Point classes for consistency. As for insideSphere, do we need a new method for that? Could we not use SphereF(pos, radius).isContained(point)? I get that this is more convenient, but it still irks me :P. At the very least, add it to all other point classes as well. Point2 should have insideCircle.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Jan 25, 2015

Contributor

Revising this to remove the two Point3F utility methods.

Contributor

crabmusket commented Jan 25, 2015

Revising this to remove the two Point3F utility methods.

@crabmusket crabmusket referenced this pull request Jan 25, 2015

Merged

Forest wind emitter #1124

@crabmusket crabmusket closed this Jan 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment