New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up and streamlining Types.h, #902

Merged
merged 1 commit into from Nov 24, 2014

Conversation

Projects
None yet
4 participants
@Winterleaf
Contributor

Winterleaf commented Nov 4, 2014

Ok, this is from we did a visit to the math inside the engine.

@crabmusket crabmusket added Bug Defect Final review and removed Bug labels Nov 4, 2014

@crabmusket crabmusket added this to the 3.6.3 milestone Nov 4, 2014

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Nov 4, 2014

Contributor

So no change to functionality, just code cleanup? As far as I can see.

Contributor

crabmusket commented Nov 4, 2014

So no change to functionality, just code cleanup? As far as I can see.

@Winterleaf

This comment has been minimized.

Show comment
Hide comment
@Winterleaf

Winterleaf Nov 4, 2014

Contributor

Yes, this is just a code cleanup/efficiency thing.

Contributor

Winterleaf commented Nov 4, 2014

Yes, this is just a code cleanup/efficiency thing.

@jamesu

This comment has been minimized.

Show comment
Hide comment
@jamesu

jamesu Nov 5, 2014

Nice but unreadable

jamesu commented on Engine/source/platform/types.h in cb161ad Nov 5, 2014

Nice but unreadable

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Nov 5, 2014

Contributor

@jamesu do you mean the endian stuff?

Contributor

crabmusket commented Nov 5, 2014

@jamesu do you mean the endian stuff?

@jamesu

This comment has been minimized.

Show comment
Hide comment
@jamesu

jamesu Nov 5, 2014

Just curious, but any particular reason why this was replaced with the F32 version?

I noted on http://graphics.stanford.edu/~seander/bithacks.html#RoundUpPowerOf2Float it seems to indicate using the FPU might be slower on systems.

jamesu commented on Engine/source/platform/types.h in cb161ad Nov 5, 2014

Just curious, but any particular reason why this was replaced with the F32 version?

I noted on http://graphics.stanford.edu/~seander/bithacks.html#RoundUpPowerOf2Float it seems to indicate using the FPU might be slower on systems.

@jamesu

This comment has been minimized.

Show comment
Hide comment
@jamesu

jamesu Nov 5, 2014

Contributor

@eightyeight I commented in the relevant area.

Contributor

jamesu commented Nov 5, 2014

@eightyeight I commented in the relevant area.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Nov 5, 2014

Contributor

I can't see your comments inline, strangely :(

Contributor

crabmusket commented Nov 5, 2014

I can't see your comments inline, strangely :(

@Areloch

This comment has been minimized.

Show comment
Hide comment
@Areloch

Areloch Nov 5, 2014

Contributor

Yeah, I'm sure it's probably fine, but man that Endian stuff is hard to read, haha.

Contributor

Areloch commented Nov 5, 2014

Yeah, I'm sure it's probably fine, but man that Endian stuff is hard to read, haha.

@crabmusket crabmusket modified the milestones: 3.7, 3.6.3 Nov 11, 2014

crabmusket added a commit that referenced this pull request Nov 24, 2014

Merge pull request #902 from Winterleaf/Types.h
Cleaning up and streamlining Types.h,

@crabmusket crabmusket merged commit 9150afe into GarageGames:development Nov 24, 2014

1 check passed

default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment