New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Alpha LOD to tsStatic objects. #910

Merged
merged 3 commits into from Dec 7, 2014

Conversation

Projects
None yet
7 participants
@Winterleaf
Contributor

Winterleaf commented Nov 6, 2014

This allows designers to set the start and end distance for Alpha LOD on objects.

Added Alpha LOD to tsStatic objects.
This allows designers to set the start and end distance for Alpha LOD on objects.

@crabmusket crabmusket added this to the 3.7 milestone Nov 6, 2014

@Areloch

This comment has been minimized.

Show comment
Hide comment
@Areloch

Areloch Nov 14, 2014

Contributor

Seems to work fine.

Contributor

Areloch commented Nov 14, 2014

Seems to work fine.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Nov 14, 2014

Contributor

So this fades between LOD levels?

Contributor

crabmusket commented Nov 14, 2014

So this fades between LOD levels?

@Winterleaf

This comment has been minimized.

Show comment
Hide comment
@Winterleaf

Winterleaf Nov 14, 2014

Contributor

Actually it will fade the object based on distance

Contributor

Winterleaf commented Nov 14, 2014

Actually it will fade the object based on distance

@andr3wmac

This comment has been minimized.

Show comment
Hide comment
@andr3wmac

andr3wmac Nov 14, 2014

Contributor

I don't know if this should be referred to as LOD. I think that gives the false impression that it's a substitute for LOD on a mesh. Enabling this will not gain any performance. It's more of a visual effect than anything. AlphaDistanceFade or something to that extent?

Contributor

andr3wmac commented Nov 14, 2014

I don't know if this should be referred to as LOD. I think that gives the false impression that it's a substitute for LOD on a mesh. Enabling this will not gain any performance. It's more of a visual effect than anything. AlphaDistanceFade or something to that extent?

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Nov 14, 2014

Contributor

Agreed, this isn't really a level of detail.

Contributor

crabmusket commented Nov 14, 2014

Agreed, this isn't really a level of detail.

@Winterleaf

This comment has been minimized.

Show comment
Hide comment
@Winterleaf

Winterleaf Nov 15, 2014

Contributor

OK with me

Contributor

Winterleaf commented Nov 15, 2014

OK with me

@Areloch

This comment has been minimized.

Show comment
Hide comment
@Areloch

Areloch Nov 17, 2014

Contributor

I guess I misread it, but I figured it did that.

If it doesn't, would it be easy to just have a conditional that if the AlphaLOD is 0, we just return out from the prepRenderImage?

At that point, it would operate as a 'nice' distance fade so we don't have to draw stuff at distance.

Contributor

Areloch commented Nov 17, 2014

I guess I misread it, but I figured it did that.

If it doesn't, would it be easy to just have a conditional that if the AlphaLOD is 0, we just return out from the prepRenderImage?

At that point, it would operate as a 'nice' distance fade so we don't have to draw stuff at distance.

@Winterleaf

This comment has been minimized.

Show comment
Hide comment
@Winterleaf

Winterleaf Nov 20, 2014

Contributor

Ok, updated the code to use the word Fade versus LOD, I believe thats what you guys wanted.

Contributor

Winterleaf commented Nov 20, 2014

Ok, updated the code to use the word Fade versus LOD, I believe thats what you guys wanted.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Nov 20, 2014

Contributor

Sounds great, thanks :). I'll review this tonight.

Contributor

crabmusket commented Nov 20, 2014

Sounds great, thanks :). I'll review this tonight.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Nov 21, 2014

Contributor

@Winterleaf what do you see being the use for this, and why is fade distance not a property of the client connection or mission, like visible distance?

Contributor

crabmusket commented Nov 21, 2014

@Winterleaf what do you see being the use for this, and why is fade distance not a property of the client connection or mission, like visible distance?

@Winterleaf

This comment has been minimized.

Show comment
Hide comment
@Winterleaf

Winterleaf Nov 21, 2014

Contributor

The purpose of this was for customizing scenes where you might have a lot of statics in it, and you want the distance to fade away and not pop in an out.

Contributor

Winterleaf commented Nov 21, 2014

The purpose of this was for customizing scenes where you might have a lot of statics in it, and you want the distance to fade away and not pop in an out.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Nov 21, 2014

Contributor

Okay, makes sense. Again, why an object property not a client or scene property?

Contributor

crabmusket commented Nov 21, 2014

Okay, makes sense. Again, why an object property not a client or scene property?

@Winterleaf

This comment has been minimized.

Show comment
Hide comment
@Winterleaf

Winterleaf Nov 22, 2014

Contributor

So that you can fine tune the scene.

Contributor

Winterleaf commented Nov 22, 2014

So that you can fine tune the scene.

crabmusket added a commit that referenced this pull request Dec 7, 2014

Merge pull request #910 from Winterleaf/StaticShapeAlphaLod
Added distance fading to TSStatic objects.

@crabmusket crabmusket merged commit e0436ef into GarageGames:development Dec 7, 2014

1 check passed

default Merged build finished.
Details
addField( "Alpha Fade Start", TypeF32, Offset(mAlphaFadeStart, TSStatic), "Distance of start Alpha Fade" );
addField( "Alpha Fade End", TypeF32, Offset(mAlphaFadeEnd, TSStatic), "Distance of end Alpha Fade" );
addField( "Alpha Fade Inverse", TypeBool, Offset(mInvertAlphaFade, TSStatic), "Invert Alpha Fade's Start & End Distance" );
endGroup( "AlphaFade" );

This comment has been minimized.

@crabmusket

crabmusket Dec 12, 2014

Contributor

Um... how did we not catch this.

@crabmusket

crabmusket Dec 12, 2014

Contributor

Um... how did we not catch this.

This comment has been minimized.

@LuisAntonRebollo

LuisAntonRebollo Dec 12, 2014

Contributor

Fixed on #1040

@LuisAntonRebollo

This comment has been minimized.

@Winterleaf

Winterleaf Dec 13, 2014

Contributor

What didn’t we catch?

@Winterleaf

Winterleaf Dec 13, 2014

Contributor

What didn’t we catch?

This comment has been minimized.

@Azaezel

Azaezel Dec 13, 2014

Contributor

Spaces in var names.

@Azaezel

Azaezel Dec 13, 2014

Contributor

Spaces in var names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment