New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved God Ray PostFX #969

Merged
merged 2 commits into from Dec 22, 2014

Conversation

Projects
None yet
3 participants
@crabmusket
Contributor

crabmusket commented Nov 28, 2014

Add control for the number of samples and other controls for God Rays shader. See this.

Improved God Ray
Add control for the number of samples and other controls for God Rays
shader.

@crabmusket crabmusket added this to the 3.7 milestone Nov 28, 2014

@Areloch

This comment has been minimized.

Show comment
Hide comment
@Areloch

Areloch Dec 2, 2014

Contributor

Gave this a whirl.

Idea's good, but the settings allow for waaaay too large a range. It's too easy to completely blow out the effect to a screen of pure white.

I'd say we fiddle around with it to try and get an idea for a good range the settings should have.

Contributor

Areloch commented Dec 2, 2014

Gave this a whirl.

Idea's good, but the settings allow for waaaay too large a range. It's too easy to completely blow out the effect to a screen of pure white.

I'd say we fiddle around with it to try and get an idea for a good range the settings should have.

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Dec 3, 2014

Contributor

👍

Contributor

crabmusket commented Dec 3, 2014

👍

@crabmusket

This comment has been minimized.

Show comment
Hide comment
@crabmusket

crabmusket Dec 21, 2014

Contributor

I think the brightness and samples are things that can be caused to balance each other out. Decay values > 1 were a problem, so I fixed the range there - same with density. But otherwise I think this is good to go.

Contributor

crabmusket commented Dec 21, 2014

I think the brightness and samples are things that can be caused to balance each other out. Decay values > 1 were a problem, so I fixed the range there - same with density. But otherwise I think this is good to go.

crabmusket added a commit that referenced this pull request Dec 22, 2014

@crabmusket crabmusket merged commit 450a6c6 into GarageGames:development Dec 22, 2014

@crabmusket crabmusket deleted the crabmusket:options-for-godrays branch Dec 22, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment