New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

const U64 maxValPerChannel = (U64)1 << mBitsPerChannel; #984

Merged
merged 1 commit into from Nov 30, 2014

Conversation

Projects
None yet
4 participants
@Azaezel
Contributor

Azaezel commented Nov 30, 2014

No description provided.

@LuisAntonRebollo

This comment has been minimized.

Show comment
Hide comment
@LuisAntonRebollo

LuisAntonRebollo Nov 30, 2014

Thx for this fix :)

LuisAntonRebollo commented on bea3563 Nov 30, 2014

Thx for this fix :)

LuisAntonRebollo added a commit that referenced this pull request Nov 30, 2014

Merge pull request #984 from Azaezel/mBitsPerChannel_match_DX_OGL
const U64 maxValPerChannel = (U64)1 << mBitsPerChannel;

@LuisAntonRebollo LuisAntonRebollo merged commit c916e7d into GarageGames:development Nov 30, 2014

1 check passed

default Merged build finished.
Details

@crabmusket crabmusket added this to the OpenGL3 milestone Nov 30, 2014

@@ -333,7 +333,7 @@ Var* GBufferConditionerGLSL::_conditionOutput( Var *unconditionedOutput, MultiLi
// Encode depth into two channels
if(mNormalStorageType != CartesianXYZ)
{
const U64 maxValPerChannel = 1 << mBitsPerChannel;
const U64 maxValPerChannel = (U64)1 << mBitsPerChannel;

This comment has been minimized.

@dottools

dottools Nov 30, 2014

What's with the extra space indention?

@dottools

dottools Nov 30, 2014

What's with the extra space indention?

This comment has been minimized.

@LuisAntonRebollo

LuisAntonRebollo Nov 30, 2014

Contributor

Fixed on #989

@LuisAntonRebollo

LuisAntonRebollo Nov 30, 2014

Contributor

Fixed on #989

@Azaezel Azaezel deleted the Azaezel:mBitsPerChannel_match_DX_OGL branch Dec 1, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment