Removed unnecessary async/await methods #5

Merged
merged 1 commit into from Sep 13, 2013

Conversation

Projects
None yet
2 participants
@semihokur
Contributor

semihokur commented Sep 8, 2013

I am a PhD student in the CS department at the University of Illinois. I'm currently doing research on asynchronous programming in phone applications. I developed a tool that automatically improves async/await usages by doing transformations.

The tool found some opportunities in your application. There was no need to use async/await for some methods. It will decrease the overhead that is caused by async/await state machine and it will simplify the code. Removing async/await does not change the behavior at all.

Are you interested in merging this pull request? If not, please let me know why.

Thanks for your time!

garyjohnson added a commit that referenced this pull request Sep 13, 2013

Merge pull request #5 from semihokur/master
Removed unnecessary async/await methods

@garyjohnson garyjohnson merged commit 7013492 into garyjohnson:master Sep 13, 2013

@garyjohnson

This comment has been minimized.

Show comment
Hide comment
@garyjohnson

garyjohnson Nov 14, 2013

Owner

I had to revert this commit as it broke unit tests and the application itself.

Owner

garyjohnson commented on 46fcc49 Nov 14, 2013

I had to revert this commit as it broke unit tests and the application itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment