Gary Jones GaryJones

Organizations

@copyblogger @WordPress-Coding-Standards @gamajo
GaryJones commented on pull request bradyvercher/gistpress#57
@GaryJones

Thanks for this @armab. I'll try and find time to take a look at this over the (busy) weekend (unless @bradyvercher beats me to it), and get it mer…

@GaryJones

.min file that doesn't seem to be minified?

@GaryJones

parseInt() should always be given the second arg (radix), which defines which number base to use. https://developer.mozilla.org/en-US/docs/Web/Java…

@GaryJones

Whitespace.

@GaryJones

calculates its core => calculate it's score.

@GaryJones

has => have (since "posts" is plural)

GaryJones commented on issue Yoast/wordpress-seo#167
@GaryJones

I think that would be a good case for a Extension (free / premium) or Yoast SEO Premium feature that would add a UI for creating custom breadcrumb …

@GaryJones
Breadcrumb markup
@GaryJones

WPCS for PHP doesn't actually specify a space before ( or not for closures simply because they aren't being used in core. For WPCS for JS, a space …

@GaryJones

This block seems to be indented one level too many?

@GaryJones

Early returns / guard clauses are usually a good thing. Why was this one removed?

GaryJones commented on pull request Yoast/wordpress-seo#2746
GaryJones commented on pull request Yoast/wordpress-seo#2746
@GaryJones

Could you assign $( '#' + taxonomyName + 'checklist input[type="checkbox"]) to a variable, and then filter() with :checked / :not(:checked) as need…

GaryJones commented on pull request Yoast/wordpress-seo#2746
@GaryJones

@return, singular.

GaryJones commented on pull request Yoast/wordpress-seo#2746
@GaryJones

Sets. No apostrophe needed.

GaryJones commented on pull request Yoast/wordpress-seo#2746
@GaryJones

Should be able to avoiding having the same variable cast to an int twice.

GaryJones commented on pull request Yoast/wordpress-seo#2746
@GaryJones

The .wpseo-make-primary-term link (button) above has spans for screen readers, but I don't think those won't be viewable by screen readers since th…

GaryJones commented on pull request Yoast/wordpress-seo#2746
@GaryJones

Does this need both a context and a translator comment?

GaryJones commented on pull request Yoast/wordpress-seo#2746
@GaryJones

esc_html_e()

GaryJones commented on pull request Yoast/wordpress-seo#2746
@GaryJones

Does this href get populated with something later? If not, then a <button> (style like a link if you wish) is more semantically correct and more ac…

GaryJones commented on pull request Yoast/wordpress-seo#2746
@GaryJones

The FILTER_SANITIZE_NUMBE_INT filter "Remove all characters except digits, plus and minus sign", so does there need to be a check for an empty stri…

GaryJones commented on pull request Yoast/wordpress-seo#2746
@GaryJones

Any benefit in casting the result of this apply_filters() to an array, so you definitely know that what's cached is an array?

GaryJones commented on pull request Yoast/wordpress-seo#2746
@GaryJones

Could this gsc line have a // Google Search Console comment, so the abbreviation is a little less cryptic?

GaryJones commented on pull request Yoast/wordpress-seo#2746
@GaryJones

Instead of creating these dependencies in the constructor, could these be injected in to the constructor when an object from this class is created?

@GaryJones
Disable Yoast SEO wording
GaryJones commented on issue Yoast/wordpress-seo#2708
@GaryJones

Presumably any options, but I didn't test them all. I allowed author sitemaps, I excluded subscribers, and I excluded a CPT, and each time, I could…

GaryJones commented on issue Yoast/wordpress-seo#2708
@GaryJones

On a different site, changing the XML sitemap options results in the sitemap_index.xml becoming a WP 404. Re-visiting Settings->Permalinks fixes it…

@GaryJones
GaryJones created repository GaryJones/wp-credits