Skip to content

Geoffroy Couprie
Geal

Organizations

@unhosted @LoginPeople
Geal commented on pull request Geal/nom#216
@Geal

Why put back take_while_s!(&str -> bool)? It's not a &str as argument

Geal commented on pull request Geal/nom#214
@Geal

Thanks!

Geal pushed to master at Geal/nom
@Geal
Geal merged pull request Geal/nom#214
@Geal
Fix take_while_s and take_while1_s doc entries.
2 commits with 7 additions and 7 deletions
Geal commented on pull request Geal/nom#209
@Geal

Thanks!

Geal pushed to master at Geal/nom
@Geal
Geal merged pull request Geal/nom#209
@Geal
opt test addition
1 commit with 5 additions and 3 deletions
Geal pushed to master at Geal/nom
@Geal
Geal merged pull request Geal/nom#184
@Geal
Updated tag and test macro and test overhaul
2 commits with 32 additions and 18 deletions
Geal commented on pull request Geal/nom#184
@Geal

Thanks for putting up with my demands! We will get through all these pull requests ;)

Geal commented on pull request Geal/nom#208
@Geal

Thanks!

Geal pushed to master at Geal/nom
@Geal
Geal merged pull request Geal/nom#208
@Geal
opt_res test overhaul
1 commit with 5 additions and 3 deletions
Geal commented on pull request Geal/nom#204
@Geal

It is a lot easier to debug code if the slices are right where the assert is. With the following: assert_eq!(pair_abc_def(done), Done(rest, (parsed_1

Geal closed pull request Geal/nom#193
@Geal
Add method making/consuming macros redux
Geal commented on pull request Geal/nom#193
@Geal

Hi! I just assembled your commits in one and pushed it to master (commit cf2ee25). It looks good so far. I'm happy to see this merged at last! Next…

Geal pushed to master at Geal/nom
@Geal
Geal commented on pull request Geal/nom#204
@Geal

After reading a few of these, I'm not sure defining all the input and output slices before the asserts improves the readability. Having all the rel…

Geal commented on pull request Geal/nom#199
@Geal

Thanks!

Geal pushed to master at Geal/nom
@Geal
Geal merged pull request Geal/nom#199
@Geal
count_fixed_no_type test overhaul
1 commit with 21 additions and 11 deletions
Geal pushed to master at Geal/nom
@Geal
Geal merged pull request Geal/nom#197
@Geal
count_zero test overhaul
1 commit with 27 additions and 9 deletions
Geal commented on pull request Geal/nom#197
@Geal

Thanks!

Geal commented on pull request Geal/nom#184
@Geal

Could you squash the "test overhaul" commit and its revert?

Geal commented on pull request Geal/nom#192
@Geal

Also, can you do a git pull --rebase when you integrate the changes from master? It makes the history easier to follow

Geal commented on pull request Geal/nom#192
@Geal

what is the str.rs file you added at the top level? The pull request still contains 38 commits, with lots of test code. You can reduce them easily …

Geal commented on pull request Geal/nom#183
@Geal

I think I would be happier about a take_while_n! and take_till_n!, it would be more general, and can provide the same features

Geal commented on pull request Geal/nom#192
@Geal

Hi, could you squash a bit this commit history? 39 commits is a bit much :) Also, could you add a short sentence at the top of the documentation fo…

Something went wrong with that request. Please try again.