FindCLHEP is obsolete; CLHEP follows cmake standard #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For use of a system CLHEP this file breaks the cmake build.
|
Thanks for the PR - as this repo is only for mirroring releases, I've added an entry in our Bugzilla mapping to it. https://bugzilla-geant4.kek.jp/show_bug.cgi?id=1934 Further updates will be made on that ticket, and I'll close the PR (it cannot be merged here) once the Bugzilla is marked RESOLVED CLOSED. |
|
Thanks!
…On Mon, Jan 16, 2017 at 05:56:55AM -0800, Ben Morgan wrote:
Thanks for the PR - as this repo is only for mirroring releases, I've added an entry in our Bugzilla mapping to it.
https://bugzilla-geant4.kek.jp/show_bug.cgi?id=1934
Further updates will be made on that ticket, and I'll close the PR (it cannot be merged here) once the Bugzilla is marked RESOLVED CLOSED.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#1 (comment)
--
Whitney R. Armstrong
|
|
This is now fixed in the main SVN repo in tag cmake-V10-03-11. Note that additional changes other than simple removal of FindCLHEP were required. The fix may just make the upcoming patch to 10.3, but I can't guarantee this. |
|
FYI it is still a problem. FindCLHEP.cmake should not be installed. A stand alone CLHEP install does not need a find moudle. It works just find in "config" mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For use of a system CLHEP this file breaks the cmake build.