Improve the branch ratio consistency in RDM: use the enum instead of number #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. The proposed modifications are now pushed in the development master and will be included in next public release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Geant4 developers,
In RDM, the definitions of the different radioactive decay modes can be found in G4RadioactiveDecayMode.hh. However, the index used in the branch ratio could be different from the number in G4RadioactiveDecayMode.hh. This will cause the problem for some new added decay modes, for example, the Triton decay. So in this PR, the index numbers are all replaced by the enum defined in G4RadioactiveDecayMode.hh.
Tao