Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CKEditor - check upload image src url is https if Geeklog site is https #891

Open
eSilverStrike opened this issue Sep 5, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@eSilverStrike
Copy link
Member

commented Sep 5, 2018

A request from the forum by OMAL: https://www.geeklog.net/forum/viewtopic.php?showtopic=96878

So I request the feature, if possible, that check url for outside image src include https, not http, when your site protocol is https.

Currently, users can create http-links for images even when the domain is https, that end up with the page requested by the browser marked as unsecured.

Related to #890

@eSilverStrike eSilverStrike added this to the 2.2.1 milestone Sep 5, 2018

@eSilverStrike

This comment has been minimized.

Copy link
Member Author

commented Sep 5, 2018

My only concern would be if the external site that hosts the image is only available in http: and not https.

For images linking on the same server it should definitely be https if the Geeklog site is already https.

If CKEditor cannot pick up on this then maybe some type of warning on save of the item (comment, story, etc...) from Geeklog? This may be difficult to do since Geeklog automatically strip/change text from content on save for other things like censor and bad html and not provide a warning. Maybe a config option to automatically change http to https for images on save of content???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.