Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actual code should be massively linted #80

Closed
4 tasks done
XaviTorello opened this issue Oct 14, 2020 · 0 comments · Fixed by #81
Closed
4 tasks done

Actual code should be massively linted #80

XaviTorello opened this issue Oct 14, 2020 · 0 comments · Fixed by #81
Assignees
Labels
arch & CI arch team backend Dev team bug Something isn't working

Comments

@XaviTorello
Copy link

Checklist

  • I have verified that that issue exists against the master branch.
  • I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
  • This is not a usage question. (Those should be directed to the Slack instead.)
  • I have reduced the issue to the simplest possible case.

Describe the bug
Current code is not well formatted and does not accomplish our agreed standards, so check-code action will raise for each new PR.

$ pre-commit run --all

[INFO] Initializing environment for https://github.com/pycqa/isort.
[INFO] Initializing environment for https://github.com/pycqa/isort:toml.
[INFO] Initializing environment for https://github.com/ambv/black.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Installing environment for https://github.com/pycqa/isort.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/ambv/black.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
isort....................................................................Failed
- hook id: isort
- files were modified by this hook

Fixing /Users/photopills/Projects/anemperfeina/tests/jobsapp/test_jopsapp.py
Fixing /Users/photopills/Projects/anemperfeina/tests/factories.py
Fixing /Users/photopills/Projects/anemperfeina/tests/accounts/test_accounts.py
Fixing /Users/photopills/Projects/anemperfeina/jobsapp/views/employer.py
Fixing /Users/photopills/Projects/anemperfeina/jobs/settings/testing.py
Skipped 12 files

black....................................................................Failed
- hook id: black
- files were modified by this hook

reformatted /Users/photopills/Projects/anemperfeina/tests/accounts/test_accounts.py
reformatted /Users/photopills/Projects/anemperfeina/tests/jobsapp/test_jopsapp.py
reformatted /Users/photopills/Projects/anemperfeina/tests/factories.py
All done! ✨ 🍰 ✨
3 files reformatted, 44 files left unchanged.

Expected behavior
Current master code should be fixed to ensure that each PR identifies just the changes that they introduces.

Screenshots
https://github.com/GeeksCAT/anem-per-feina/runs/1252512799?check_suite_focus=true
image

@XaviTorello XaviTorello added bug Something isn't working backend Dev team arch & CI arch team labels Oct 14, 2020
@XaviTorello XaviTorello added this to To do in HF'20 :: Frontend via automation Oct 14, 2020
@XaviTorello XaviTorello self-assigned this Oct 14, 2020
XaviTorello added a commit that referenced this issue Oct 14, 2020
HF'20 :: Frontend automation moved this from To do to Done Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch & CI arch team backend Dev team bug Something isn't working
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant