Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for custom fonts #397

Closed
wants to merge 10 commits into from
Closed

Add support for custom fonts #397

wants to merge 10 commits into from

Conversation

wcandillon
Copy link
Contributor

Add family property to the Icon component in order to use custom fonts via the createIconSet function of https://github.com/oblador/react-native-vector-icons

@wcandillon wcandillon mentioned this pull request Jan 3, 2017
Merged
stallings
stallings approved these changes Jan 10, 2017
View reviewed changes
Copy link

@stallings stallings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wcandillon wcandillon mentioned this pull request Jan 13, 2017
Merged
@sankhadeeproy007
Copy link
Contributor

@wcandillon We missed this! Will merge it sometime next week. Thanks!

@shivrajkumar
Copy link
Collaborator

@wcandillon This will definitely help in using more that one Icon fontFamily.
But this PR is incomplete. To implement the above, both https://github.com/GeekyAnts/NativeBase/blob/master/src/basic/Icon/index.js and https://github.com/GeekyAnts/NativeBase/blob/master/src/basic/IconNB.js needs to be modified.
We will look into it and try to implement this.
Or you can send a PR implementing the same.

@andidev
Copy link

andidev commented Jun 13, 2017

Was this closed due to inactivity? Or was this feature added in latest master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stallings stallings stallings approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wcandillon @sankhadeeproy007 @shivrajkumar @andidev @stallings