Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make looping property to work as intended #965

Merged
merged 1 commit into from Jun 19, 2017

Conversation

@mu29
Copy link
Contributor

@mu29 mu29 commented Jun 19, 2017

Problem

this.props.looping || true will always set the looping state to true (Not only undefined but also false)

Solution

Set this.state.looping to true only if this.props.looping is undefined

@shivrajkumar shivrajkumar self-assigned this Jun 19, 2017
@shivrajkumar shivrajkumar merged commit bc429d4 into GeekyAnts:master Jun 19, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants