Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list input of qc functions can be provided by the user with the config file #48

Closed
1 of 2 tasks
Tracked by #45
Geet-George opened this issue Nov 2, 2023 · 2 comments · Fixed by #46
Closed
1 of 2 tasks
Tracked by #45

list input of qc functions can be provided by the user with the config file #48

Geet-George opened this issue Nov 2, 2023 · 2 comments · Fixed by #46
Assignees
Milestone

Comments

@Geet-George
Copy link
Owner

Geet-George commented Nov 2, 2023

For the user to be able to provide a list of qc functions, this will have to be incorporated in a pipeline which calls the apply_qc_checks function for each Sonde instance as part of the QC.

@Geet-George Geet-George mentioned this issue Nov 2, 2023
5 tasks
@Geet-George Geet-George changed the title this list input of qc functions can be provided by the user with the config file list input of qc functions can be provided by the user with the config file Nov 2, 2023
@Geet-George Geet-George self-assigned this Nov 2, 2023
@Geet-George Geet-George added this to the QC milestone Nov 2, 2023
@Geet-George Geet-George linked a pull request Nov 2, 2023 that will close this issue
@Geet-George
Copy link
Owner Author

Instead of incorporating the user's QC functions into the pipeline, the user can provide the list of QC checks to run as part of the function argument for the apply_qc_checks function.

@Geet-George
Copy link
Owner Author

Closing this as it is now implemented in #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant